Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libmount/2.33.1 #123

Merged
merged 3 commits into from
Oct 10, 2019
Merged

add libmount/2.33.1 #123

merged 3 commits into from
Oct 10, 2019

Conversation

ericLemanissier
Copy link
Contributor

libmount/2.33.1

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'libmount/2.33.1' have failed:

  • Linux x86_64, Release, gcc 5, libstdc++ . Options: libmount:shared:True
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [FPIC MANAGEMENT (KB-H007)] 'fPIC' option not managed correctly. Please remove it for Windows configurations: del self.options.fpic (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H007)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@ericLemanissier
Copy link
Contributor Author

How can the fPIC hook fail with

    def configure(self):
        del self.settings.compiler.libcxx
        if self.settings.os != "Linux":
            raise ConanInvalidConfiguration("only Linux is supported")

?

@uilianries
Copy link
Member

@ericLemanissier you found a bug! hahaha

@uilianries
Copy link
Member

Added a new hotfix for Conan Center hooks: conan-io/hooks#80

Co-Authored-By: Michael "Croydon" Keck <cr0ydon@outlook.com>
@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

Some configurations of 'libmount/2.33.1' have failed:

  • Linux x86_64, Release, gcc 5, libstdc++ . Options: libmount:shared:True
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [FPIC MANAGEMENT (KB-H007)] 'fPIC' option not managed correctly. Please remove it for Windows configurations: del self.options.fpic (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H007)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@ericLemanissier
Copy link
Contributor Author

@uilianries the same error happenned. Mayne the hook was not updated yet?

@ericLemanissier
Copy link
Contributor Author

on a strange note, the hook accepted #82 whereas the fpic option is never deleted

@danimtb
Copy link
Member

danimtb commented Sep 30, 2019

@ericLemanissier you are right, there is a bug in the check of the hook. It is checking for "fpic" while the #82 recipe has 'fpic' 🤦‍♂

https://github.com/conan-io/hooks/blob/cb81c492ecd32559754f11d83c56ee93a5f6d317/hooks/conan-center.py#L150

@uilianries
Copy link
Member

@ericLemanissier you are right, there is a bug in the check of the hook. It is checking for "fpic" while the #82 recipe has 'fpic' man_facepalming

:trollface:

@conan-center-bot
Copy link
Collaborator

Some configurations of 'libmount/2.33.1' have failed:

  • Linux x86_64, Release, gcc 5, libstdc++ . Options: libmount:shared:True
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [FPIC MANAGEMENT (KB-H007)] 'fPIC' option not managed correctly. Please remove it for Windows configurations: del self.options.fpic (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H007)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@conan-center-bot
Copy link
Collaborator

Some configurations of 'libmount/2.33.1' have failed:

  • Linux x86_64, Release, gcc 5, libstdc++ . Options: libmount:shared:True
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [FPIC MANAGEMENT (KB-H007)] 'fPIC' option not managed correctly. Please remove it for Windows configurations: del self.options.fpic (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H007)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@conan-center-bot
Copy link
Collaborator

Some configurations of 'libmount/2.33.1' have failed:

  • Linux x86_64, Release, gcc 5, libstdc++ . Options: libmount:shared:True
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [FPIC MANAGEMENT (KB-H007)] 'fPIC' option not managed correctly. Please remove it for Windows configurations: del self.options.fpic (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H007)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@conan-center-bot
Copy link
Collaborator

All green! 😊

@ericLemanissier
Copy link
Contributor Author

yay, thanks for conan-io/hooks#80 @uilianries

recipes/libmount/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libmount/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

Some configurations of 'libmount/2.33.1' have failed:

@conan-center-bot
Copy link
Collaborator

All green! 😊

@conan-center-bot
Copy link
Collaborator

All green! 😊

@conan-center-bot
Copy link
Collaborator

All green! 😊

@danimtb danimtb merged commit 518af78 into conan-io:master Oct 10, 2019
@ericLemanissier ericLemanissier deleted the libmount branch October 10, 2019 09:54
artem-kamyshev pushed a commit to artem-kamyshev/conan-center-index that referenced this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants