Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add odbc/2.3.7 #82

Merged
merged 2 commits into from
Sep 26, 2019
Merged

add odbc/2.3.7 #82

merged 2 commits into from
Sep 26, 2019

Conversation

ericLemanissier
Copy link
Contributor

odbc/2.3.7

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'odbc/2.3.7' have failed:

  • Windows x86_64, Debug, Visual Studio 15, MDd. Options: odbc:shared:True
    • Hooks errors detected:
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Package for Visual Studio does not contain artifacts with these extensions: ['lib', 'dll', 'exe'] (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Packaged artifacts does not match the settings used: os=Windows, compiler=Visual Studio (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
      • [HOOK - conan-center.py] post_package(): ERROR: [SHARED ARTIFACTS (KB-H015)] Package with 'shared' option did not contains any shared artifact (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H015)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@ericLemanissier
Copy link
Contributor Author

Well, yes, all windows configurations don't build anything. they just provide the library names which are provided by the compiler (MSVC and MinGW). This does not match CCI's model. What do you suggest in this situation?

uilianries
uilianries requested changes Sep 24, 2019
View reviewed changes
recipes/odbc/all/conanfile.py Outdated Show resolved Hide resolved
recipes/odbc/all/conanfile.py Outdated Show resolved Hide resolved
recipes/odbc/all/conanfile.py Outdated Show resolved Hide resolved
recipes/odbc/all/conanfile.py Outdated Show resolved Hide resolved
recipes/odbc/all/conanfile.py Outdated Show resolved Hide resolved
recipes/odbc/all/conanfile.py Show resolved Hide resolved
@uilianries
Copy link
Member

Well, yes, all windows configurations don't build anything. they just provide the library names which are provided by the compiler (MSVC and MinGW). This does not match CCI's model. What do you suggest in this situation?

If we can't provide Windows support due author limitation, let's drop the support.

@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

1 similar comment
@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

Some configurations of 'odbc/2.3.7' have failed:

  • Windows x86_64, Debug, Visual Studio 15, MDd. Options: odbc:shared:True
    • Hooks errors detected:
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Package for Visual Studio does not contain artifacts with these extensions: ['lib', 'dll', 'exe'] (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
      • [HOOK - conan-center.py] post_package(): ERROR: [MATCHING CONFIGURATION (KB-H014)] Packaged artifacts does not match the settings used: os=Windows, compiler=Visual Studio (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H014)
      • [HOOK - conan-center.py] post_package(): ERROR: [SHARED ARTIFACTS (KB-H015)] Package with 'shared' option did not contains any shared artifact (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H015)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

All green! 😊

lasote
lasote reviewed Sep 26, 2019
View reviewed changes
recipes/odbc/all/conanfile.py
del self.settings.compiler.libcxx # Pure C
del self.settings.compiler.cppstd
if self.settings.os == "Windows":
raise ConanInvalidConfiguration("Windows not supported yet. Please, open an issue if you need such support")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lasote lasote merged commit b1d0693 into conan-io:master Sep 26, 2019
@ericLemanissier ericLemanissier mentioned this pull request Sep 30, 2019
Merged
4 tasks
@danimtb danimtb mentioned this pull request Sep 30, 2019
Closed
artem-kamyshev pushed a commit to artem-kamyshev/conan-center-index that referenced this pull request Sep 28, 2020
@worldemar
disable darwin_ssl for libcurl on macOS (conan-io#82)
09f649a
datalogics-robb pushed a commit to datalogics-robb/conan-center-index that referenced this pull request Sep 3, 2024
@datalogics-josepha
Merge pull request conan-io#82 from rgailiunas/develop
7d83ccd 
Revert PR 72 & 74 Remove maxmem flag from libjpeg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasote lasote lasote left review comments

@uilianries uilianries uilianries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ericLemanissier @CLAassistant @conan-center-bot @uilianries @lasote