-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bandit #12816
Add bandit #12816
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add a test_v1_package folder, following the template https://github.com/conan-io/conan-center-index/tree/master/docs/package/all/test_v1_package
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
@MartinDelille sorry, it's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good to go, only small details.
def layout(self): | ||
cmake_layout(self) | ||
|
||
def generate(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can avoid it by declaring "CMakeToolchain" as generator, but using explicitly is more than welcome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so I leave it like that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MartinDelille yes, you can leave generate with CMakeToolchain always.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
All green in build 8 (
|
* Add bandit * Apply suggestions from code review Co-authored-by: Uilian Ries <uilianries@gmail.com> * Add test_v1_package * fix test_v1_package * Remove empty line * Fix c++11 management since set_compile_features doesn't work * Use target_compile_features * Use target_compile_features in test_package * Apply suggestions from code review Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>
…develop * 'master' of github.com:conan-io/conan-center-index: (801 commits) (conan-io#12310) Update qxmpp to use Qt 6.2.4 (conan-io#12960) [bot] Add Access Request users (2022-09-15) (conan-io#12959) [linter] Convert import ConanFile from conans into an error (conan-io#12816) Add bandit (conan-io#12922) gemmlowp: conan v2 support (conan-io#12725) update drogon to 1.8.0 (conan-io#12910) bump dependencies of vulkan-validationlayers; partial conan v2 upgrade (conan-io#12920) wslay: conan v2 support (conan-io#12945) [docs] Hotfix replace wrong cmake method in docs (conan-io#12940) cpp-httplib: add version 0.11.2 (conan-io#12937) [flatbuffers] Add 2.0.6 (conan-io#12936) [xnnpack] Add cci.20220801 (conan-io#12934) docs: 2.0 migration guidance for subfolders (conan-io#12932) aws-c-cal: add 0.5.19 + conan v2 support + improve build on Apple (conan-io#12927) aws-checksums: conan v2 support (conan-io#12926) aws-c-compression: conan v2 support (conan-io#12925) add parson/1.4.0 (conan-io#12921) fast-cdr: conan v2 support (conan-io#12918) ninja: conan v2 support & drop 1.9.0 (conan-io#12917) voropp: conan v2 support + fix download of source code ... Conflicts: recipes/cmake/3.x.x/conanfile.py recipes/doxygen/all/conanfile.py
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!