Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libffi: Support Conan V2 #13355

Merged
merged 47 commits into from
Oct 24, 2022
Merged

Conversation

jwillikers
Copy link
Contributor

Specify library name and version: libffi/*

Forked off of #12904.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@jwillikers jwillikers changed the title libffi: Support Conan V2 Draft: libffi: Support Conan V2 Oct 7, 2022
@jwillikers jwillikers marked this pull request as draft October 7, 2022 20:38
@jwillikers jwillikers changed the title Draft: libffi: Support Conan V2 libffi: Support Conan V2 Oct 7, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jwillikers
Copy link
Contributor Author

Oh, I bet this is related to conan-io/conan#11867.

@SpaceIm
Copy link
Contributor

SpaceIm commented Oct 12, 2022

Oh, I bet this is related to conan-io/conan#11867.

How? I see Visual Studio errors in this PR, so it's not related to conan-io/conan#11867

@conan-center-bot

This comment has been minimized.

@jwillikers jwillikers closed this Oct 21, 2022
@jwillikers jwillikers reopened this Oct 21, 2022
@planetmarshall planetmarshall mentioned this pull request Oct 21, 2022
4 tasks
@conan-center-bot

This comment has been minimized.

This is no longer building and I don't know why.
It's also from 2014, so hopefully it's okay to drop.
@jwillikers
Copy link
Contributor Author

Version 3.2.1 is causing a bit of trouble on Windows and I don't want to pull forward a bunch of Windows-related patches for the msvcpp.sh wrapper. I'm dropping 3.2.1 to get this working, but let me know if we need to keep that version.

@conan-center-bot

This comment has been minimized.

prince-chrismc
prince-chrismc previously approved these changes Oct 24, 2022
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits

recipes/libffi/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libffi/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libffi/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libffi/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

All green in build 39 (9eb26830471cbb4ad81f59251a52194cf4ef2b40):

  • libffi/3.4.2@:
    All packages built successfully! (All logs)

  • libffi/3.3@:
    All packages built successfully! (All logs)

  • libffi/3.4.3@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 0bab4d3 into conan-io:master Oct 24, 2022
@jwillikers jwillikers deleted the libffi-v2 branch October 24, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants