Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cairo] update toolchain #13427

Merged
merged 9 commits into from
Oct 28, 2022
Merged

[cairo] update toolchain #13427

merged 9 commits into from
Oct 28, 2022

Conversation

planetmarshall
Copy link
Contributor

Specify library name and version: cairo

Update the cairo meson build to the new toolchains

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Oct 11, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@planetmarshall
Copy link
Contributor Author

planetmarshall commented Oct 12, 2022 •
edited
Loading

Failing due to conan-io/conan#11867. Freetype needs updating. See #13451

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@planetmarshall
Copy link
Contributor Author

retry when #13355 is merged.

@ghost ghost mentioned this pull request Oct 23, 2022
Closed
@ghost
Copy link

ghost commented Oct 23, 2022

I detected other pull requests that are modifying cairo/meson recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Oct 23, 2022
Closed
4 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 374a25b
cairo/1.17.4 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo.2.dylib' links to system library 'CoreGraphics' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo.dylib' links to system library 'CoreGraphics' but it is not in cpp_info.frameworks.

@conan-center-bot

This comment has been minimized.

Sign in to view
prince-chrismc
prince-chrismc reviewed Oct 25, 2022
View reviewed changes
recipes/cairo/meson/conanfile.py Outdated
Comment on lines 159 to 161
options["xcb"] = is_enabled(self.options.get_safe("with_xcb"))
options["xlib"] = is_enabled(self.options.get_safe("with_xlib"))
options["xlib-xrender"] = is_enabled(self.options.get_safe("with_xlib_xrender"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we lose get save since these should be present?

prince-chrismc
prince-chrismc reviewed Oct 25, 2022
View reviewed changes
recipes/cairo/meson/conanfile.py Outdated
Comment on lines 191 to 192
if is_apple_os(self) and Version(self.version) <= "1.17.4":
# This was fixed in the meson build from 1.17.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not exactly match comment?

Suggested change
if is_apple_os(self) and Version(self.version) <= "1.17.4":
# This was fixed in the meson build from 1.17.6
if is_apple_os(self) and Version(self.version) < "1.17.6":
# This was fixed in the meson build from 1.17.6

prince-chrismc
prince-chrismc reviewed Oct 25, 2022
View reviewed changes
recipes/cairo/meson/test_v1_package/CMakeLists.txt Outdated

find_package(cairo CONFIG REQUIRED)

add_executable(${PROJECT_NAME} ../test_package/test_package.c)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, there as a new way for this https://github.com/conan-io/conan-center-index/blob/master/docs/package_templates/cmake_package/all/test_v1_package/CMakeLists.txt

less code :)

prince-chrismc
prince-chrismc reviewed Oct 25, 2022
View reviewed changes
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question https://github.com/conan-io/conan-center-index/pull/13427/files#r1004991794

Otherwise it's perfect

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 12 (4e3a0b28d272649653aef33c5f91d46150ed3ec8):

  • cairo/1.17.4@:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 7b03f3d into conan-io:master Oct 28, 2022
@planetmarshall planetmarshall deleted the cairo-new-toolchain branch March 4, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@planetmarshall @conan-center-bot @uilianries @prince-chrismc