Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glib: several fixes & improvements #13440

Merged
merged 14 commits into from
Oct 28, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Oct 12, 2022

  • fix PkgConfigDeps
  • bump dependencies
  • relocatable shared libs on macOS (install_name set to @rpath)
  • properly rename lib names for compiler=msvc as well
  • no need to define libdir in MesonToolchain since min conan version is 1.52.0
  • add tests for CMakeDeps & PkgConfigDeps
  • use basic_layout (for consistency among CCI recipes)

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@ghost
Copy link

ghost commented Oct 12, 2022

I detected other pull requests that are modifying glib/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Oct 12, 2022

[ 50%] Building C object CMakeFiles/test_package.dir/test_package.c.o
[100%] Linking C executable test_package
/Users/jenkins/w/prod/BuildSingleReference@4/conan-center-index/recipes/glib/all/test_package/test_package.c:17:5: warning: ignoring return value of function declared with const attribute [-Wunused-value]
    g_module_supported();
    ^~~~~~~~~~~~~~~~~~
1 warning generated.
clang: error: no such file or directory: '/Users/jenkins/w/prod/BuildSingleReference@4/.conan/data/libffi/3.4.3/_/_/package/f0ce0f189afed95b41fb2faad2f2225a7eca0d22/Frameworks'
make[2]: *** [test_package] Error 1
make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
make: *** [all] Error 2

Issue in PkgConfigDeps of test_package coming from libffi recipe. See conan-io/conan#11867. it's something making conan v2 migration tedious.

Waiting layout addition in #13355 & #13445

@SpaceIm SpaceIm mentioned this pull request Oct 12, 2022
4 tasks
def generate(self):

env = VirtualBuildEnv(self)
env.generate()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see it used anywhere... why is it needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there are build requirements. My understanding is that it's implicit in conan v2 mode, but not in conan v1 mode by default.

uilianries
uilianries previously approved these changes Oct 17, 2022
SSE4
SSE4 previously approved these changes Oct 17, 2022
@ghost ghost mentioned this pull request Oct 20, 2022
4 tasks
@SpaceIm SpaceIm dismissed stale reviews from SSE4 and uilianries via 8edeea7 October 24, 2022 21:24
@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm closed this Oct 24, 2022
@SpaceIm SpaceIm reopened this Oct 24, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Oct 26, 2022
4 tasks
@conan-center-bot
Copy link
Collaborator

All green in build 8 (b65fb36160a40172299d6290c3b214682bb682ed):

  • glib/2.74.0@:
    All packages built successfully! (All logs)

  • glib/2.71.3@:
    All packages built successfully! (All logs)

  • glib/2.73.0@:
    All packages built successfully! (All logs)

  • glib/2.73.1@:
    All packages built successfully! (All logs)

  • glib/2.68.3@:
    All packages built successfully! (All logs)

  • glib/2.73.2@:
    All packages built successfully! (All logs)

  • glib/2.72.1@:
    All packages built successfully! (All logs)

  • glib/2.70.4@:
    All packages built successfully! (All logs)

  • glib/2.73.3@:
    All packages built successfully! (All logs)

  • glib/2.69.3@:
    All packages built successfully! (All logs)

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit b65fb36
glib/2.68.3
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libglib-2.0.so' links to system library 'm' but it is not in cpp_info.system_libs.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 448575a into conan-io:master Oct 28, 2022
@SpaceIm SpaceIm deleted the glib-more-conan-v2 branch October 28, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants