Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jemalloc conan2 #18690

Closed
wants to merge 28 commits into from
Closed

jemalloc conan2 #18690

wants to merge 28 commits into from

Conversation

jabbas
Copy link
Contributor

@jabbas jabbas commented Jul 19, 2023

jemalloc/5.2.1
jemalloc/5.3.0

This is continuation of work of @0xFireWolf from that PR: #17722


@github-actions
Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/jemalloc//'.

👋 @Hopobcn you might be interested. 😉

@ghost
Copy link

ghost commented Jul 19, 2023

I detected other pull requests that are modifying jemalloc/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@jabbas
Copy link
Contributor Author

jabbas commented Jul 20, 2023

If there's a way to distinguish if we are running in container vs native i would add additional check for forcing that vaddr setting

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@RubenRBS RubenRBS self-assigned this Sep 8, 2023
0xFireWolf and others added 18 commits September 15, 2023 10:46
…nd use it to initialize `self.cpp_info.libs`.
@conan-center-bot

This comment has been minimized.

Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jabbas thanks a lot for your patience :)

I've reviewed the PR and it looks good. The only remaining issue is the current build fail, and I'd say this would then bee good to merge!

I've pushed 2 minor fixes to the recipe now that we're on it. I'm worried about the xmalloc thing. This seems to have been a typo of the original PR, as otherwise that option was not used. It seems to work locally for me, but I'd appreciate it if you could double check :)

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 6 (0675bbd769e08db6b705f7826463582323912ae9):

  • jemalloc/5.2.1:
    CI failed to create some packages (All logs)

    Logs for packageID 3351525b86ae76e433445f442868ab9f6d6392b7:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=Visual Studio
    compiler.runtime=MD
    compiler.version=16
    os=Windows
    [options]
    jemalloc:shared=True
    
    [...]
    cl : Command line warning D9025 : overriding '/MT' with '/MD'
    cl : Command line warning D9025 : overriding '/MT' with '/MD'
    cl : Command line warning D9025 : overriding '/MT' with '/MD'
    cl : Command line warning D9025 : overriding '/MT' with '/MD'
    cl : Command line warning D9025 : overriding '/MT' with '/MD'
    cl : Command line warning D9025 : overriding '/MT' with '/MD'
    cl : Command line warning D9025 : overriding '/MT' with '/MD'
    cl : Command line warning D9025 : overriding '/MT' with '/MD'
    cl : Command line warning D9025 : overriding '/MT' with '/MD'
    cl : Command line warning D9025 : overriding '/MT' with '/MD'
    cl : Command line warning D9025 : overriding '/MT' with '/MD'
    cl : Command line warning D9025 : overriding '/MT' with '/MD'
    cl : Command line warning D9025 : overriding '/MT' with '/MD'
    make: Circular src/jemalloc.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/arena.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/background_thread.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/base.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/bin.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/bitmap.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/ckh.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/ctl.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/div.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/extent.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/extent_dss.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/extent_mmap.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/hash.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/hook.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/large.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/log.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/malloc_io.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/mutex.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/mutex_pool.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/nstime.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/pages.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/prng.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/prof.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/rtree.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/safety_check.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/stats.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/sc.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/sz.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/tcache.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/test_hooks.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/ticker.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/tsd.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    make: Circular src/witness.sym.obj <- include/jemalloc/internal/private_namespace.gen.h dependency dropped.
    jemalloc/5.2.1: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    [HOOK - conan-center.py] post_package_info(): ERROR: [LIBRARY DOES NOT EXIST (KB-H054)] Component jemalloc::jemalloc library 'jemalloc' is listed in the recipe, but not found installed at self.cpp_info.libdirs. Make sure you compiled the library correctly. If so, then the library name should probably be fixed. Otherwise, then the component should be removed. (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H054-LIBRARY-DOES-NOT-EXIST) 
    ERROR: 
    	ConanException: [HOOK - conan-center.py] post_package_info(): Some checks failed running the hook, check the output
    
  • jemalloc/5.3.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 5 (0675bbd769e08db6b705f7826463582323912ae9):

  • jemalloc/5.3.0:
    Didn't run or was cancelled before finishing

  • jemalloc/5.2.1:
    CI failed to create some packages (All logs)

    Logs for packageID fdb2c0c7b78e642e54e7dc2109213226e06dce44:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.cppstd=14
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=192
    os=Windows
    [options]
    */*:shared=True
    
    [...]
    jemalloc/5.2.1 (test package): CMakeToolchain generated: conan_toolchain.cmake
    jemalloc/5.2.1 (test package): CMakeToolchain generated: CMakePresets.json
    jemalloc/5.2.1 (test package): CMakeToolchain generated: ..\..\..\CMakeUserPresets.json
    jemalloc/5.2.1 (test package): Generator 'CMakeDeps' calling 'generate()'
    jemalloc/5.2.1 (test package): Generator 'VirtualRunEnv' calling 'generate()'
    jemalloc/5.2.1 (test package): Generating aggregated env files
    jemalloc/5.2.1 (test package): Generated aggregated env files: ['conanrun.bat', 'conanbuild.bat']
    
    ======== Testing the package: Building ========
    jemalloc/5.2.1 (test package): Calling build()
    jemalloc/5.2.1 (test package): Running CMake.configure()
    jemalloc/5.2.1 (test package): RUN: cmake -G "Visual Studio 16 2019" -DCMAKE_TOOLCHAIN_FILE="C:/J2/w/prod-v2/bsr@3/cci-daa21f25/recipes/jemalloc/all/test_package/build/msvc-192-x86_64-14-release/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="C:/J2/w/prod-v2/bsr@3/cci-daa21f25/recipes/jemalloc/all/test_package" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" "C:\J2\w\prod-v2\bsr@3\cci-daa21f25\recipes\jemalloc\all\test_package"
    -- Using Conan toolchain: C:/J2/w/prod-v2/bsr@3/cci-daa21f25/recipes/jemalloc/all/test_package/build/msvc-192-x86_64-14-release/generators/conan_toolchain.cmake
    -- Conan toolchain: C++ Standard 14 with extensions OFF
    -- The C compiler identification is MSVC 19.29.30148.0
    -- The CXX compiler identification is MSVC 19.29.30148.0
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe - skipped
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Conan: Target declared 'jemalloc::jemalloc'
    CMake Error at build/msvc-192-x86_64-14-release/generators/cmakedeps_macros.cmake:67 (message):
      Library 'jemalloc' not found in package.  If 'jemalloc' is a system
      library, declare it with 'cpp_info.system_libs' property
    Call Stack (most recent call first):
      build/msvc-192-x86_64-14-release/generators/jemalloc-Target-release.cmake:24 (conan_package_library_targets)
      build/msvc-192-x86_64-14-release/generators/jemallocTargets.cmake:26 (include)
      build/msvc-192-x86_64-14-release/generators/jemalloc-config.cmake:16 (include)
      CMakeLists.txt:4 (find_package)
    
    
    -- Configuring incomplete, errors occurred!
    See also "C:/J2/w/prod-v2/bsr@3/cci-daa21f25/recipes/jemalloc/all/test_package/build/msvc-192-x86_64-14-release/CMakeFiles/CMakeOutput.log".
    
    *********************************************************
    Recipe 'jemalloc/5.2.1 (test package)' cannot build its binary
    It is possible that this recipe is not Conan 2.0 ready
    If the recipe comes from ConanCenter check: https://conan.io/cci-v2.html
    If it is your recipe, check if it is updated to 2.0
    *********************************************************
    
    ERROR: jemalloc/5.2.1 (test package): Error in build() method, line 20
    	cmake.configure()
    	ConanException: Error 1 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@Jihadist
Copy link
Contributor

Ping. Are there any chances for this pr?

@RubenRBS
Copy link
Member

Finally ported, closing this one, thanks a lot for your initial contribution! :)

@RubenRBS RubenRBS closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants