Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jemalloc: migrate to Conan v2 #21509

Merged
merged 32 commits into from
Jan 15, 2024
Merged

jemalloc: migrate to Conan v2 #21509

merged 32 commits into from
Jan 15, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Nov 30, 2023

Continues #17722.

0xFireWolf and others added 27 commits November 30, 2023 14:19
@0xFireWolf @valgur
jemalloc: Make the recipe compatible with Conan 2.x.
c6e7c8d
@0xFireWolf @valgur
jemalloc: Add the patch that adds support for Visual Studio 2019 and …
ada20bf 
…2022.
@0xFireWolf @valgur
jemalloc: Revise the implementation of validate().
5b2ef57
@0xFireWolf @valgur
jemalloc: Define the env variable CC if jemalloc is compiled by MSVC.
bb03687
@0xFireWolf @valgur
jemalloc: Fix the typo.
1462ffe
@0xFireWolf @valgur
jemalloc: Patch configure.ac to add the missing description in `AC_…
c51c14e 
…DEFINE`, fixing the autoreconf errors.
@0xFireWolf @valgur
jemalloc: Add automake to the build requirements.
621692f
@0xFireWolf @valgur
jemalloc: Remove the patch that adds the solution files of MSVC 2019 …
332383f 
…and 2022.
@0xFireWolf @valgur
jemalloc: Do not check whether the math library exists when jemalloc …
e26f01b 
…is compiled by MSVC.
@0xFireWolf @valgur
jemalloc: Remove deprecated functions that set the arguments for Auto…
962106c 
…tools.
@0xFireWolf @valgur
jemalloc: Revise the function that computes the name of the library a…
6494229 
…nd use it to initialize `self.cpp_info.libs`.
@0xFireWolf @valgur
jemalloc: Add the patch file that adds the missing description in `AC…
86bbdf8 
…_DEFINE` for v5.3.0.
@0xFireWolf @valgur
jemalloc: Remove the function that patches the file configure.ac.
41bcc0b
@0xFireWolf @valgur
jemalloc: Remove deprecated implementation of package() and `packag…
313d3ac 
…e_info()`.
@0xFireWolf @valgur
jemalloc: Copy MSVC compatible headers to the package folder.
c47fe45
@0xFireWolf @valgur
jemalloc: Remove the old implementation of _library_name().
8f46416
@0xFireWolf @valgur
jemalloc: Use the helper is_msvc() instead of checking the compiler…
049a501 
… value manually.
@0xFireWolf @valgur
jemalloc: Remove the old implementation of build().
030ab88
@0xFireWolf @valgur
jemalloc: Remove the deprecated function _msvc_build_type().
207e117
@0xFireWolf @valgur
jemalloc: No need to call autoreconf.
ab2f17a
@0xFireWolf @valgur
jemalloc: Add the missing CXX flags for MSVC.
16b6c97
@0xFireWolf @valgur
jemalloc: Support for Apple Silicon Macs is only available as of 5.3.0.
d4e1f6c
@0xFireWolf @valgur
jemalloc: Remove unneeded _patch_sources() function.
6b6df79
@0xFireWolf @valgur
jemalloc: Fix the linter warnings.
d08a480
@0xFireWolf @valgur
jemalloc: No need to set the configuration arguments `--enable-shared…
e33d513 
…/static` manually.
@valgur
jemalloc: adjust compiler version checks
0afdcaa
@valgur
jemalloc: convert test_package to C
90f5098
@github-actions GitHub Actions
Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/jemalloc//'.

👋 @Hopobcn you might be interested. 😉

@valgur valgur mentioned this pull request Nov 30, 2023
Closed
@ghost
Copy link

ghost commented Nov 30, 2023

I detected other pull requests that are modifying jemalloc/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Nov 30, 2023
Closed
@prince-chrismc prince-chrismc mentioned this pull request Nov 30, 2023
Open
@RubenRBS RubenRBS self-assigned this Nov 30, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit 5eddcad
jemalloc/5.3.0@#d40d52fec4bfce45074fd51cfae9b95e 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libjemalloc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libjemalloc.2.dylib, libjemalloc.dylib
jemalloc/5.2.1@#9ce8714bf24d32eed2f76c94dd942c40 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libjemalloc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libjemalloc.2.dylib, libjemalloc.dylib

jwillikers
jwillikers suggested changes Dec 18, 2023
View reviewed changes
recipes/jemalloc/all/conanfile.py Outdated Show resolved Hide resolved
@valgur @jwillikers
jemalloc: use tool_requires()
87ffcde 
Co-authored-by: Jordan Williams <jordan@jwillikers.com>
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (87ffcdea1034610b2bf53336d4d68810aa21a5cb):

  • jemalloc/5.2.1:
    All packages built successfully! (All logs)

  • jemalloc/5.3.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 6 (87ffcdea1034610b2bf53336d4d68810aa21a5cb):

  • jemalloc/5.3.0:
    All packages built successfully! (All logs)

  • jemalloc/5.2.1:
    All packages built successfully! (All logs)

@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit 87ffcde
jemalloc/5.2.1@#15c99a0f8adf16a66aa5928f4191cba3 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libjemalloc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libjemalloc.2.dylib, libjemalloc.dylib
jemalloc/5.3.0@#1deb9d1c836d40b85554ab3a3f5b352e 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libjemalloc.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libjemalloc.2.dylib, libjemalloc.dylib

@conan-center-bot conan-center-bot merged commit b848bcb into conan-io:master Jan 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubenRBS RubenRBS RubenRBS approved these changes

@jwillikers jwillikers jwillikers approved these changes

@franramirez688 franramirez688 Awaiting requested review from franramirez688

Assignees

@RubenRBS RubenRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@valgur @conan-center-bot @RubenRBS @jwillikers @uilianries @0xFireWolf