Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtr: migrate to Conan v2 #21111

Merged
merged 7 commits into from
Mar 12, 2024
Merged

xtr: migrate to Conan v2 #21111

merged 7 commits into from
Mar 12, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Nov 14, 2023

@conan-center-bot

This comment has been minimized.

@RubenRBS RubenRBS self-assigned this Nov 15, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

recipes/xtr/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (a83d8663d6d1cf9e758b5ec53ba107010adf8fa9):

  • xtr/2.1.0:
    All packages built successfully! (All logs)

  • xtr/1.0.1:
    All packages built successfully! (All logs)

  • xtr/2.0.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (a83d8663d6d1cf9e758b5ec53ba107010adf8fa9):

  • xtr/2.1.0:
    All packages built successfully! (All logs)

  • xtr/2.0.1:
    All packages built successfully! (All logs)

  • xtr/1.0.1:
    All packages built successfully! (All logs)

Comment on lines -6 to -11
"2.0.0":
folder: all
"1.0.1":
folder: all
"1.0.0":
folder: all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for deleting versions? I think it would be better to leave them in, to avoid breaking anyone's build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not really directly affect the availability of these versions, they simply become "unmaintained". Updates to the recipe are published as new revisions, all old revisions are kept intact.

The standard practice on CCI is to keep all major versions, if possible, and a few latest minor versions. Only the latest patch version is typically kept around. This is done to limit the size of the CI builds, mostly, and to reduce maintenance burden if the recipes require a lot of patching.

https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/sources_and_patches.md#supported-versions

@choll
Copy link
Contributor

choll commented Mar 4, 2024

@uilianries @RubenRBS are you able to review? thanks

@ghost
Copy link

ghost commented Mar 4, 2024

I detected other pull requests that are modifying xtr/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit a34410f into conan-io:master Mar 12, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants