Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glib: add v2.80.0 #23559

Closed
wants to merge 7 commits into from
Closed

glib: add v2.80.0 #23559

wants to merge 7 commits into from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Apr 15, 2024

Continues from #23193. Related to #23557 and conan-io/conan-docker-tools#554 (comment)

Adds self.tool_requires("cpython/3.12.2") and installs a pinned version of packaging from PyPI locally into the build folder.

The published package artifacts on PyPI are immutable, so the pinned version will provide reproducible builds and is reflected in the package hash via the conanfile.py contents, if I'm not mistaken.

I think this approach is a simple and scalable way to deal with build-scope Python dependencies on CCI in general.

Edit: @ericLemanissier pointed out to me that the packaging dependency is a transitive build dep. Since we decided not to package it separately, the only option left was to vendor the two required files. Which I did.

@conan-center-bot

This comment has been minimized.

it introduces a cyclic dependency with gobject-introspection
@conan-center-bot

This comment has been minimized.

because pkg-config is not installed on macos runners
@ericLemanissier
Copy link
Contributor

The build is now finished. You can take a look at the results here

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (d94cbd4fccf490f9b2225e4dfb6d8b432a00f620):

  • glib/2.80.0:
    All packages built successfully! (All logs)

  • glib/2.78.3:
    All packages built successfully! (All logs)

  • glib/2.78.1:
    All packages built successfully! (All logs)

  • glib/2.77.1:
    All packages built successfully! (All logs)

  • glib/2.78.0:
    All packages built successfully! (All logs)

  • glib/2.77.3:
    All packages built successfully! (All logs)

  • glib/2.77.2:
    All packages built successfully! (All logs)

  • glib/2.77.0:
    All packages built successfully! (All logs)

  • glib/2.76.3:
    All packages built successfully! (All logs)

  • glib/2.75.3:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (d94cbd4fccf490f9b2225e4dfb6d8b432a00f620):

  • glib/2.80.0:
    All packages built successfully! (All logs)

  • glib/2.78.0:
    All packages built successfully! (All logs)

  • glib/2.78.3:
    All packages built successfully! (All logs)

  • glib/2.78.1:
    All packages built successfully! (All logs)

  • glib/2.77.3:
    All packages built successfully! (All logs)

  • glib/2.77.1:
    All packages built successfully! (All logs)

  • glib/2.77.0:
    All packages built successfully! (All logs)

  • glib/2.76.3:
    All packages built successfully! (All logs)

  • glib/2.75.3:
    All packages built successfully! (All logs)

  • glib/2.77.2:
    All packages built successfully! (All logs)

Copy link
Contributor

@ericLemanissier ericLemanissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@memsharded @uilianries I think this PR is implementing the solution you had in mind in conan-io/conan-docker-tools#554 (comment)
Can we get a review in order to finally make progress ?

@valgur
Copy link
Contributor Author

valgur commented Jul 12, 2024

Closing as superseded by #24591. Most of the changes here were related to the Python 3.12 issues.

@valgur valgur closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants