glib: refactor test package #24054
glib: refactor test package #24054
Conversation
|
The build is now finished. You can take a look at the results here |
There was a problem hiding this comment.
the PR description could be reworded to match the actual change: Remove pkg-config from the test, and use only CMake on all platforms
Because apart from that, the test is not more minimal (same test_package.c, and same executable is run), there is no suppression of either heavy logic or binary blob
| if self.settings.os == "Macos": | ||
| env = Environment() | ||
| # Avoid conflicts with system libiconv | ||
| # see: https://github.com/conan-io/conan-center-index/pull/17610#issuecomment-1552921286 | ||
| env.define_path("DYLD_FALLBACK_LIBRARY_PATH", "$DYLD_LIBRARY_PATH") | ||
| env.define_path("DYLD_LIBRARY_PATH", "") | ||
| env.vars(self, scope="run").save_script("conanrun_macos_runtimepath") |
There was a problem hiding this comment.
it looks like this is still needed, cf https://github.com/ericLemanissier/proof-of-conan/actions/runs/9177037237/job/25233751761#step:8:2039
ghost
mentioned this pull request
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 5 (
|
|
The build is now finished. You can take a look at the results here |
Simplify the test_package in according to our policies:
symbols, the runtime linker can resolve symbols).