Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[arrow] Fix typos + test using cmake_find_package #2592

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Aug 18, 2020

Specify library name and version: arrow/1.0.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@jgsogo jgsogo mentioned this pull request Aug 18, 2020
4 tasks
@madebr
Copy link
Contributor

madebr commented Aug 18, 2020

When building with the following command, and not removing the lib/cmake folder,

conan create . arrow/1.0.0@ -o arrow:parquet=True -o arrow:plasma=True -o arrow:gandiva=False

the following files in lib/cmake/arrow are created:

bc80bb8129066ff1ad369bc4dea6f097af21af89/lib/cmake/arrow/
├── arrow-config.cmake
├── ArrowConfig.cmake
├── ArrowConfigVersion.cmake
├── ArrowOptions.cmake
├── ArrowTargets.cmake
├── ArrowTargets-release.cmake
├── FindArrow.cmake
├── FindParquet.cmake
├── FindPlasma.cmake
├── ParquetConfig.cmake
├── ParquetConfigVersion.cmake
├── ParquetTargets.cmake
├── ParquetTargets-release.cmake
├── PlasmaConfig.cmake
├── PlasmaConfigVersion.cmake
├── PlasmaTargets.cmake
└── PlasmaTargets-release.cmake

The following pkgconfig files are generated:

bc80bb8129066ff1ad369bc4dea6f097af21af89/lib/pkgconfig/
├── arrow-compute.pc
├── arrow.pc
├── parquet.pc
└── plasma.pc

@conan-center-bot
Copy link
Collaborator

All green in build 1 (88011c2e185a5fb83b591ed19f7dc3fbeea69dc4)! 😊

@jgsogo
Copy link
Contributor Author

jgsogo commented Aug 18, 2020

From the list above, Conan is able to generate:

arrow-compute.pc <-- (not now, but possible adding the component)
arrow.pc
parquet.pc
plasma.pc

FindArrow.cmake

ArrowConfigVersion.cmake
ArrowTarget-release.cmake  <-- (should it be ArrowTargets-release.cmake?? note the extra 's')
ArrowTargets.cmake
ArrowConfig.cmake

@madebr
Copy link
Contributor

madebr commented Aug 18, 2020

arrow-compute.pc <-- (not now, but possible adding the component)

arrow-compute.pc is just a wrapper around arrow.pc:

Name: Apache Arrow Compute
Description: Compute modules for Apache Arrow
Version: 1.0.0
Requires: arrow

ArrowTarget-release.cmake <-- (should it be ArrowTargets-release.cmake?? note the extra 's')

That doesn't matter.
This file is generated using install(EXPORT ... DESTINATION lib/cmake/arrow FILE ArrowTarget.cmake).

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madebr
Copy link
Contributor

madebr commented Aug 19, 2020

Is there a conan issue about adding support for multiple FindXXX.cmake files in the generators?

@danimtb danimtb merged commit 9048415 into conan-io:master Aug 24, 2020
@jgsogo jgsogo deleted the fix/arrow branch August 24, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants