Add freeimage 3.18.0 #2672
Closed
Add freeimage 3.18.0 #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some configurations of 'freeimage/3.18.0' failed in build 1 (
|
|
Some configurations of 'freeimage/3.18.0' failed in build 2 (
|
|
Some configurations of 'freeimage/3.18.0' failed in build 3 (
|
|
Some configurations of 'freeimage/3.18.0' failed in build 4 (
|
|
Some configurations of 'freeimage/3.18.0' failed in build 5 (
|
madebr
reviewed
Sep 11, 2020
| self.copy("license-gplv2.txt", dst="licenses", src=self._source_subfolder) | ||
|
|
||
| def package_info(self): | ||
| self.cpp_info.libs = tools.collect_libs(self) |
There was a problem hiding this comment.
Suggested change
| self.cpp_info.libs = tools.collect_libs(self) | |
| self.cpp_info.libs = ["freeimageplu", "freeimage"] |
madebr
reviewed
Sep 11, 2020
Comment on lines
+95
to
+96
| self.cpp_info.names["cmake_find_package"] = "FreeImage" | ||
| self.cpp_info.names["cmake_find_package_multi"] = "FreeImage" |
There was a problem hiding this comment.
These names are not official, aren't they?
Suggested change
| self.cpp_info.names["cmake_find_package"] = "FreeImage" | |
| self.cpp_info.names["cmake_find_package_multi"] = "FreeImage" |
There was a problem hiding this comment.
That's right. I just use the most popular pattern. (Ex: https://github.com/OGRECave/ogre/blob/master/CMake/Packages/FindFreeImage.cmake)
madebr
reviewed
Sep 11, 2020
| s_plugins->AddNode(InitRAS); | ||
| s_plugins->AddNode(InitTARGA); | ||
| +#if 0 | ||
| s_plugins->AddNode(InitTIFF); |
There was a problem hiding this comment.
Isn't our libtiff recipe working?
There was a problem hiding this comment.
FreeImage need a private copy of libtiff.
There was a problem hiding this comment.
Too many modifications? Dammit.
There was a problem hiding this comment.
It's painful. Look at vcpkg port, It's really annoying
There was a problem hiding this comment.
See https://sourceforge.net/p/freeimage/discussion/36111/thread/c326f1be79/
So it's unlikely that something will be done to fix this.
There was a problem hiding this comment.
I don't really know how to fix it:
- Disabling some features and patching sources
or - Using embedded deps sources
Both have huge drawbacks.
There was a problem hiding this comment.
Okay, if you're saying that it's a lot of work to make it truly use external dependencies.
There was a problem hiding this comment.
I think that big patches to unvendor all these deps -like in the vcpkg port- are fine. The last version of freeimage is 2.5 years old.
madebr
reviewed
Sep 11, 2020
| s_plugins->AddNode(InitGIF); | ||
| s_plugins->AddNode(InitHDR); | ||
| +#if 0 | ||
| s_plugins->AddNode(InitG3); |
There was a problem hiding this comment.
What library are we missing?
Can you open an issue?
madebr
reviewed
Sep 11, 2020
| @@ -0,0 +1,155 @@ | |||
| --- Source/FreeImage/J2KHelper.cpp | |||
There was a problem hiding this comment.
If it's not too much trouble, can you upstream this patch?
I think the biggest trouble will be modifying all makefiles to add the include paths.
madebr
reviewed
Sep 11, 2020
| return self._cmake | ||
|
|
||
| def build(self): | ||
| # tools.rmdir(os.path.join(self._source_subfolder, "Source", "LibJPEG")) |
There was a problem hiding this comment.
Can libjpeg be removed? You're adding libjpeg to the requires list.
Same question for the Zlib directory.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: freeimage/3.18.0
conan-center hook activated.