paho-mqtt-c: fix cmake names #2729
Conversation
| if self.options.ssl: | ||
| target += "s" | ||
| if not self.options.shared: | ||
| target += "-static" |
There was a problem hiding this comment.
cant we just change this upstream?
what do you think? @fpagliughi
could we harmonize the paho-mqtt-c and paho-mqtt-cpp to have sane targets and find cmake names
There was a problem hiding this comment.
I propose PahoMqttC and PahoMqttCpp for find cmake names and paho::mqtt-c and paho::mqtt-cpp
we could also replace PAHO with ECLIPSE...
There was a problem hiding this comment.
and remove all the madness with static, shared, ssl etc. changes to the name
I mean we could also change the name based on zlib, xy, brotli etc. or use another crypto lib like mbedtls and also add this to the name -> becomes unmaintainable
There was a problem hiding this comment.
this is okay to provide different target names for different flavours of libraries.
e.g. in conan, we usually don't build static and shared in the same package. but, not everyone uses conan...
while without conan, it's pretty common practice to allow to build shared and static simultaneously (or another flavors, e.g. SSL on + SSL off, debug + release, 32 + 64, etc).
in this case, consumer has to somehow distinguish such flavours, and the best way is that he can refer to these libraries by different CMake targets - that's the most straightforward and obvious way.
so IMO there is nothing to be fixed upstream - just follow the upstream's naming in the recipe, doesn't matter how complicated it is.
There was a problem hiding this comment.
@SSE4 interesting that you support this :D
I guess you know the needed effort to support conan recipes across multiple years if everyone starts creating special options, names etc.
There was a problem hiding this comment.
Thing is he's right that not everyone uses conan and there are plenty of cases where builds generate multiple flavors and need different names. Unfortunate but true.
|
All green in build 3 (
|
|
I think it would be good idea to add the upstream paho-mqtt-c author @icraggs on all PR reviews for this package since he is now active on here developing this. |
|
upstream is in the process of releasing the next version of this package right now and will need to reconcile with all these changes shortly. |
|
Great news! Thanks @keysight-daryl ! |
Specify library name and version: paho-mqtt-c/all
conan-center hook activated.
targets are exported since version 1.3.2
See https://github.com/eclipse/paho.mqtt.c/blob/3148fe2d5f4b87e16266dfe559c0764e16ca0546/src/CMakeLists.txt#L308 and check targets added to
eclipse-paho-mqtt-cTargetsEXPORT