Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mikktspace 20200325 #2899

Conversation

intelligide
Copy link
Contributor

Specify library name and version: mikktspace/cci.20200325

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'mikktspace/cci.20200325' failed in build 1 (0e66d01ba748d06bf0d54bd1075da95b0e65a5c3):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'mikktspace/cci.20200325' failed in build 2 (d037ab124fbcabfabcc827c670cf4c435734a24f):

@conan-center-bot
Copy link
Collaborator

All green in build 3 (9bd8a58c4de9857f82e59aa7ce08ea9740fd164e)! 😊

Comment on lines +60 to +65
def _extracted_license(self):
content_lines = open(os.path.join(self.source_folder, self._source_subfolder, "mikktspace.h")).readlines()
license_content = []
for i in range(4, 21):
license_content.append(content_lines[i][4:-1])
return "\n".join(license_content)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the file changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an unmaintained project. I don't think this will change in the future.

Co-authored-by: Michael "Croydon" Keck <git@cr0ydon.com>
@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

All green in build 5 (cca6cfcc2234aa7b56887bed4f4b66805e0dec75)! 😊

prince-chrismc
prince-chrismc previously approved these changes Sep 14, 2020
jgsogo
jgsogo previously approved these changes Sep 14, 2020
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go.

recipes/mikktspace/all/conandata.yml Outdated Show resolved Hide resolved
recipes/mikktspace/all/conanfile.py Outdated Show resolved Hide resolved
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

All green in build 6 (bde27f1b14867f853ea501090b4df50da6eea975)! 😊

@jgsogo jgsogo requested a review from SSE4 September 17, 2020 10:50
@conan-center-bot conan-center-bot merged commit dbe68da into conan-io:master Sep 18, 2020
@jgsogo
Copy link
Contributor

jgsogo commented Sep 18, 2020

This has been merged because of 3 positive reviews: 2 from the team and 1 from the community

Congratulations! This is the first PR merged taking into account 1 approved review from the community 🎉


Still testing and supervising, the plan is to require 1 from the team and 2 from the community as said in the blogpost, this is an intermediate step while we check it is working as expected.

@intelligide intelligide deleted the new/mikktspace/20200325 branch September 18, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants