Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docopt.cpp: add 0.6.2 #348

Merged
merged 11 commits into from
Nov 26, 2019
Merged

docopt.cpp: add 0.6.2 #348

merged 11 commits into from
Nov 26, 2019

Conversation

theodelrieu
Copy link
Contributor

@theodelrieu theodelrieu commented Nov 18, 2019 •
edited
Loading

Specify library name and version: docopt.cpp/0.6.2

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'docopt.cpp/0.6.2' have failed:

  • Windows x86_64, Debug, Visual Studio 14, MTd. Options: docopt.cpp:shared-False
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_build(): ERROR: [FPIC MANAGEMENT (KB-H007)] 'fPIC' option not managed correctly. Please remove it for Windows configurations: del self.options.fpic (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H007)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@conan-center-bot
Copy link
Collaborator

All green! 😊

@uilianries
Improve conan package
dc3b8a0 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member

@theodelrieu theodelrieu#1

uilianries and others added 5 commits November 18, 2019 18:47
@uilianries
Export shared flag for MSVC
5769fb2 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@theodelrieu @uilianries
Update recipes/docopt.cpp/0.6.2/conanfile.py
ee73918 
Co-Authored-By: Uilian Ries <uilianries@gmail.com>
@theodelrieu @uilianries
Update recipes/docopt.cpp/0.6.2/conanfile.py
0ebcf47 
Co-Authored-By: Uilian Ries <uilianries@gmail.com>
@theodelrieu
Merge branch 'docopt.cpp/0.6.2' into docopt.cpp
593e9b2
@theodelrieu
Merge pull request #1 from uilianries/docopt.cpp
68534e8 
Recipe and testing improvement
@conan-center-bot
Copy link
Collaborator

Some configurations of 'docopt.cpp/0.6.2' have failed:

@conan-center-bot
Copy link
Collaborator

Some configurations of 'docopt.cpp/0.6.2' have failed:

@conan-center-bot
Copy link
Collaborator

Some configurations of 'docopt.cpp/0.6.2' have failed:

@theodelrieu
Copy link
Contributor Author

@uilianries the windows shared builds fail when running the test_package with the following message:

error while loading shared libraries: api-ms-win-crt-locale-l1-1-0.dll: cannot open shared object file: No such file or directory

Do you have any idea of what is requiring this dll?

@theodelrieu
Copy link
Contributor Author

On my machine, this dll is located in the following paths:

  • C:\Windows\SysWOW64\downlevel
  • C:\Windows\WinSxS\x86_microsoft-windows-m..namespace-downlevel_31bf3856ad364e35_10.0.17134.1_none_50c6cb8431e7428f
  • C:\Windows\System32\downlevel
  • C:\Windows\WinSxS\amd64_microsoft-windows-m..namespace-downlevel_31bf3856ad364e35_10.0.17134.1_none_ace56707ea44b3c5

The executable requires a lot of different api-ms-win-crt libs that are all in the 4 folders. I don't know what they are, nor why they are required by the test_package

@danimtb danimtb requested a review from SSE4 November 19, 2019 12:52
@theodelrieu
Copy link
Contributor Author

Interesting link about those dlls: https://social.msdn.microsoft.com/Forums/en-US/a28331ae-19a3-4a34-b3ba-1e8fd4430375/missing-apimswincore-dlls

I wonder how they can be linked directly 🤔

@theodelrieu
Copy link
Contributor Author

This one was tricky... collect_libs strikes again, since docopt installs everything into lib, collect_libs will link against both the import lib docopt.lib and the dll, which is borken.

@theodelrieu theodelrieu mentioned this pull request Nov 19, 2019
Closed
@conan-center-bot
Copy link
Collaborator

All green! 😊

uilianries
uilianries previously approved these changes Nov 19, 2019
View reviewed changes
SSE4
SSE4 reviewed Nov 20, 2019
View reviewed changes
recipes/docopt.cpp/0.6.2/test_package/conanfile.py
cmake.build()

def test(self):
if tools.cross_building(self.settings):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note affecting review
this code block appears to be recurring - maybe we need to extract helper? @danimtb @uilianries

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would need to be smarter than what's in the code (as building from win x64 to win x86 is a cross-build, but in this case we want to run the executable)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SSE4 Indeed

@conan-center-bot
Copy link
Collaborator

All green! 😊

danimtb
danimtb requested changes Nov 20, 2019
View reviewed changes
Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name of this library should be just docopt regarding the previous package in https://github.com/conan-community/conan-docopt

How is this packaged know in other dependency managers?

@uilianries
Copy link
Member

I think the name of this library should be just docopt regarding the previous package in conan-community/conan-docopt

The problem is docopt is another project. We can create both docopt and docopt.cpp since they are different.

How is this packaged know in other dependency managers?

On VCPKG docopt.cpp is called docopt. But they don't provide a C package for docopt only.
https://github.com/microsoft/vcpkg/blob/master/ports/docopt/portfile.cmake

Conda has both packages, following the correct names:
https://github.com/conda-forge/docopt-feedstock
https://github.com/conda-forge/docopt.cpp-feedstock

@danimtb
Copy link
Member

danimtb commented Nov 20, 2019

So docopt is the C library and docopt.cpp is the C++ one?

@uilianries
Copy link
Member

So docopt is the C library and docopt.cpp is the C++ one?

Yes, but the C++ version is not a wrapper, it's totally written in C++, but following the exactly same behavior.

@danimtb danimtb self-assigned this Nov 26, 2019
@danimtb danimtb merged commit 28941ef into conan-io:master Nov 26, 2019
@theodelrieu theodelrieu deleted the docopt.cpp/0.6.2 branch November 26, 2019 12:07
@Croydon
Copy link
Contributor

Croydon commented Nov 26, 2019

Please achieve https://github.com/conan-community/conan-docopt

@uilianries
Copy link
Member

Please achieve conan-community/conan-docopt

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@uilianries uilianries uilianries approved these changes

@danimtb danimtb danimtb approved these changes

Assignees

@danimtb danimtb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@theodelrieu @conan-center-bot @uilianries @danimtb @Croydon @SSE4