Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cpp-taskflow/2.2.0 #431

Merged
merged 10 commits into from
Jan 2, 2020
Merged

Add cpp-taskflow/2.2.0 #431

merged 10 commits into from
Jan 2, 2020

Conversation

Hopobcn
Copy link
Contributor

@Hopobcn Hopobcn commented Dec 6, 2019

Specify library name and version: cpp-taskflow/2.2.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

- Improve cppstd detection to allow C++17 & C++20
- Use cpp_info.system_libs to add pthreads dependency [conan +1.20]
@claassistantio
Copy link

claassistantio commented Dec 6, 2019

CLA assistant check
All committers have signed the CLA.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cpp-taskflow/2.2.0' have failed:

Hopobcn and others added 2 commits December 6, 2019 22:18
- Do not set settings.compiler.cppstd in test_package recipy
- Add CXX_STANDARD 17 to library properties

Co-Authored-By: Uilian Ries <uilianries@gmail.com>
cppstd check is already present in main recipy, remove checks in test recipy
@conan-center-bot
Copy link
Collaborator

Some configurations of 'cpp-taskflow/2.2.0' have failed:

uilianries
uilianries previously approved these changes Dec 6, 2019
@conan-center-bot
Copy link
Collaborator

Some configurations of 'cpp-taskflow/2.2.0' have failed:

@uilianries
Copy link
Member

Seems like apple-clang 9.1 has no support for optional

No support for std::optional before version 10.0
@uilianries
Copy link
Member

@Hopobcn According cppreference, optional is only supported since apple-clang 10

https://en.cppreference.com/w/cpp/compiler_support

uilianries
uilianries previously approved these changes Dec 6, 2019
@conan-center-bot
Copy link
Collaborator

Some configurations of 'cpp-taskflow/2.2.0' have failed:

cpp-taskflow supports Visual Studio 15.7 or greater (_MSC_VER 1914).
Restrict to the next major version.
@conan-center-bot
Copy link
Collaborator

All green! 😊

uilianries
uilianries previously approved these changes Dec 6, 2019
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally working! 👏

@Hopobcn
Copy link
Contributor Author

Hopobcn commented Dec 7, 2019

This recipy will also benefit from conan-io/conan#5997

SSE4
SSE4 previously approved these changes Dec 10, 2019
@Hopobcn Hopobcn dismissed stale reviews from SSE4 and uilianries via df7553f December 10, 2019 21:26
@conan-center-bot
Copy link
Collaborator

All green! 😊

danimtb
danimtb previously approved these changes Dec 12, 2019
@danimtb danimtb self-assigned this Dec 12, 2019
@conan-center-bot
Copy link
Collaborator

All green! 😊

@Hopobcn Hopobcn closed this Dec 20, 2019
@Hopobcn Hopobcn reopened this Dec 20, 2019
@conan-center-bot
Copy link
Collaborator

All green! 😊

@conan-center-bot
Copy link
Collaborator

All green! 😊

@danimtb danimtb merged commit 7ba0106 into conan-io:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants