-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Qt integration to sentry #5440
Merged
Merged
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ec73a62
Add Qt integration to sentry
MartinDelille 94c2472
Update recipes/sentry-native/all/conanfile.py
MartinDelille 748ef98
Add qt requirement
MartinDelille 37f8828
Set temporary qt to True
MartinDelille 1094c43
Add openssl/1.1.1j requirement
MartinDelille 71fb16b
Find conan qt patch
MartinDelille 4fdba19
Remove qt requirement
MartinDelille d24578e
Restore qt requirement and simpler patch
MartinDelille e64f7ed
Handle older version
MartinDelille e05d708
Specific patch for 0.4.7
MartinDelille 86b733b
Add missing patch
MartinDelille d763fc0
Move patch to build()
MartinDelille dc5273d
Bump openssl version to 1.1.1k
MartinDelille 9ab5bcc
Merge branch 'master' into sentry-qt
MartinDelille 51be319
touch
MartinDelille File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is qt integration by default useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but at the expense of current users who do no require it
https://docs.sentry.io/platforms/native/guides/qt/#install
Looks off by default from upstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildroot has some kind of ci system where it builds random combinations to find regressions.
Something similar where non-default option combinations are built would be useful.