Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cairo dependence on which command and failing if gtkdocize isn't installed. #7027

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

Renari
Copy link
Contributor

@Renari Renari commented Aug 24, 2021

Specify library name and version: cairo/all

The cairo package will fail to build if you don't have which installed, it also appears that it will fail without the gtkdocize command, despite autogen.sh appearing to check for the command prior to running it. autogen.sh is a fairly simple script so I moved it's functionality into the conanfile.

fixes #5674


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Aug 24, 2021

I detected other pull requests that are modifying cairo/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@Renari
Copy link
Contributor Author

Renari commented Aug 24, 2021

Hm, it looks like the gtkdoc issue originates from autoconf (which is why builds are failing).

spack/spack#23964

Same issue as above, looks like their workaround was to define GTKDOCIZE to point to echo.

@Renari Renari changed the title Remove cairo dependence on which command and failing if gtkdocice isn't installed. Remove cairo dependence on which command and failing if gtkdocize isn't installed. Aug 24, 2021
@conan-center-bot

This comment has been minimized.

@SSE4 SSE4 requested a review from uilianries August 25, 2021 16:22
Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please keep the formatting, if possible

remove dependence on which command

point GTKDOCIZE environment variable to arbitrary command

add _settings_build property
@Renari Renari requested a review from SSE4 September 27, 2021 13:07
@Renari Renari marked this pull request as ready for review September 27, 2021 13:09
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 7 (fd2b3f759d750176604efda0e8464246e647ed25):

  • cairo/1.16.0@:
    All packages built successfully! (All logs)

  • cairo/1.17.2@:
    All packages built successfully! (All logs)

  • cairo/1.17.4@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 9f8a635 into conan-io:master Sep 28, 2021
@Renari Renari deleted the cairo branch September 28, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] cairo/1.17.4: autoreconf does not find system binary gtkdocize
8 participants