cairo/all: Fix binutils 2.34 libbfd compatibility. #6712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Croydon
reviewed
Aug 6, 2021
| @@ -0,0 +1,30 @@ | |||
| --- lookup-symbol.c.original 2021-08-05 22:21:15.819998378 +0300 | |||
There was a problem hiding this comment.
Please add as a patch inline comment a URL to the upstream commit fixing this, so we know for further releases when/if we can drop it easily
There was a problem hiding this comment.
I have added more information to the patch now.
|
CI build bot failures seem unrelated to this PR. Particularly 1.16.0 and 1.17.2 were not patched at all yet throw errors. |
The libbfd is included in binutils package. In binutils 2.34 some header macros like 'bfd_get_section_flags' were removed/modified. This breaks cairo <=1.17.4 compilation with binutils >=2.34. This issue is fixed in cairo master branch, but it is not clear when we can expect a release so we resort to this ugly patch. It should work with older binutils as well. Gentoo bug for similar issue: https://bugs.gentoo.org/707846
|
Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
This was referenced Aug 24, 2021
|
Closing until #7027 gets merged to fix CI. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: cairo/1.17.4
The libbfd is included in binutils package. In binutils 2.34 some header macros like
bfd_get_section_flagswere removed/modified. This breaks cairo <=1.17.4 compilation with binutils >=2.34.This issue is fixed in cairo master branch, but it is not clear when we can expect a release so we resort to this ugly patch. It should work with older binutils as well.
Gentoo bug for similar issue: https://bugs.gentoo.org/707846
Tested locally with binutils 2.34. Will rely on CI to test for older versions.
conan-center hook activated.