-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cairo/all: Fix binutils 2.34 libbfd compatibility. #6712
Conversation
This comment has been minimized.
This comment has been minimized.
@@ -0,0 +1,30 @@ | |||
--- lookup-symbol.c.original 2021-08-05 22:21:15.819998378 +0300 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add as a patch inline comment a URL to the upstream commit fixing this, so we know for further releases when/if we can drop it easily
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added more information to the patch now.
CI build bot failures seem unrelated to this PR. Particularly 1.16.0 and 1.17.2 were not patched at all yet throw errors. |
The libbfd is included in binutils package. In binutils 2.34 some header macros like 'bfd_get_section_flags' were removed/modified. This breaks cairo <=1.17.4 compilation with binutils >=2.34. This issue is fixed in cairo master branch, but it is not clear when we can expect a release so we resort to this ugly patch. It should work with older binutils as well. Gentoo bug for similar issue: https://bugs.gentoo.org/707846
Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Closing until #7027 gets merged to fix CI. |
Specify library name and version: cairo/1.17.4
The libbfd is included in binutils package. In binutils 2.34 some header macros like
bfd_get_section_flags
were removed/modified. This breaks cairo <=1.17.4 compilation with binutils >=2.34.This issue is fixed in cairo master branch, but it is not clear when we can expect a release so we resort to this ugly patch. It should work with older binutils as well.
Gentoo bug for similar issue: https://bugs.gentoo.org/707846
Tested locally with binutils 2.34. Will rely on CI to test for older versions.
conan-center hook activated.