Add proj/6.3.0 #751

btashton · 2020-01-30T07:30:10Z

Specify library name and version: proj/6.3.0

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2020-01-30T07:41:42Z

Some configurations of 'proj/6.3.0' failed in build 2 (b6f9a0cea1630bdd9fbc3e9ab5b55c841a8ec983):

Linux x86_64, Release, gcc 5, libstdc++ . Options: proj:shared-True
Access to all the logs

conan-center-bot · 2020-01-30T07:47:32Z

All green in build 1 (96fb8a5c628f4bb253876996d8b4b513350cd07a)! 😊

proj/6.3.0: Generated 130 packages. All logs here

conan-center-bot · 2020-01-30T08:03:02Z

Some configurations of 'proj/6.3.0' failed in build 3 (d2ee7a494947cb2d33ad53256cefb395a495d6a4):

Linux x86_64, Release, gcc 5, libstdc++ . Options: proj:shared-True
Access to all the logs

btashton · 2020-01-30T08:25:22Z

We don't build the sqlite3 binary as part of the sqlite3 package in CCI, so instead I added a python script to build the database which I think will make this build. This seems really hacky, but I'm not sure what a better solution would be.

conan-center-bot · 2020-01-30T08:30:09Z

Some configurations of 'proj/6.3.0' failed in build 4 (1abdd974d5f76f6f011bc9e86361736cec97df60):

Linux x86_64, Release, gcc 5, libstdc++ . Options: proj:shared-True
Access to all the logs

conan-center-bot · 2020-01-30T08:51:00Z

Some configurations of 'proj/6.3.0' failed in build 5 (ca730f751c817a2abee662f2b758c0c671b19cfe):

Windows x86_64, Debug, Visual Studio 14, MTd. Options: proj:shared-False
Access to all the logs

conan-center-bot · 2020-01-30T09:28:12Z

Some configurations of 'proj/6.3.0' failed in build 6 (0a6742269d7b9443a70975ce308ca26c5d501dd9):

Windows x86_64, Debug, Visual Studio 15, MDd. Options: proj:shared-True
- Hooks errors detected:
  - [HOOK - conan-center.py] post_package(): ERROR: [SHARED ARTIFACTS (KB-H015)] Package with 'shared' option did not contains any shared artifact (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H015)
- Log download
- Log error Download
- Profile
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: proj:shared-True
- Hooks errors detected:
  - [HOOK - conan-center.py] post_package(): ERROR: [SHARED ARTIFACTS (KB-H015)] Package with 'shared' option did not contains any shared artifact (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H015)
- Log download
- Log error Download
- Profile
Access to all the logs

conan-center-bot · 2020-01-30T10:00:32Z

Some configurations of 'proj/6.3.0' failed in build 7 (24607b67061994e6ee6c4fea3a86781d5f0ac24b):

Linux x86_64, Release, gcc 5, libstdc++ . Options: proj:shared-False
Access to all the logs

recipes/proj/all/patches/0001-Include-libdl-for-sqlite.patch

recipes/proj/all/conanfile.py

recipes/proj/all/test_package/CMakeLists.txt

recipes/proj/all/CMakeLists.txt

conan-center-bot · 2020-01-30T18:30:26Z

Some configurations of 'proj/6.3.0' failed in build 8 (1d3ec5a593a4a8a11f90b3e2804fa48c99c4197c):

Linux x86_64, Release, gcc 4.9, libstdc++ . Options: proj:shared-True
Access to all the logs
Linux x86_64, Release, gcc 4.9, libstdc++ . Options: proj:shared-False
Access to all the logs
Linux x86_64, Debug, gcc 4.9, libstdc++ . Options: proj:shared-True
Access to all the logs
Linux x86_64, Debug, gcc 4.9, libstdc++ . Options: proj:shared-False
Access to all the logs

Signed-off-by: Brennan Ashton <bashton@brennanashton.com>

conan-center-bot · 2020-01-31T04:26:20Z

Some configurations of 'proj/6.3.0' failed in build 9 (2a255c5e055f536356edecfc3f51a2a2f78e9664):

Windows x86_64, Release, Visual Studio 16, MD. Options: proj:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 16, MDd. Options: proj:shared-True
Access to all the logs
Windows x86_64, Debug, Visual Studio 14, MDd. Options: proj:shared-False
Access to all the logs

conan-center-bot · 2020-01-31T05:05:55Z

All green in build 10 (de0f7321b4c7582a2cf8b5e2aac26cfb277bc6cf)! 😊

proj/6.3.0: Generated 130 packages. All logs here

SpaceIm · 2020-02-06T13:08:38Z

recipes/proj/all/conanfile.py

+import os
+
+
+class LibaecConan(ConanFile):


ProjConan instead of LibaecConan ;)

conan-center-bot · 2020-03-05T09:41:54Z

All green in build 11 (de0f7321b4c7582a2cf8b5e2aac26cfb277bc6cf)! 😊

proj/6.3.0: Generated 130 packages. All logs here

uilianries · 2020-03-05T20:35:33Z

libtiff and curl are optional in this project and can be added as optional dependencies: https://github.com/OSGeo/PROJ/blob/master/CMakeLists.txt#L147

SpaceIm · 2020-03-05T22:08:43Z

@uilianries Not in 6.x.x.
7.0.0 was released 4 days ago.

uilianries · 2020-03-06T17:03:29Z

My mistake! I didn't check that version!

uilianries · 2020-03-06T17:04:37Z

I'll wait for a new PR for 7.0 😉

danimtb · 2020-03-12T12:01:15Z

recipes/proj/all/sqlite_init.py

@@ -0,0 +1,7 @@
+import sqlite3


I think this is quite a hack as well, but I see we don't have the executable in the sqlite3 packages so it is the only way to go for now.

On the other hand, this might fail for Conan users that are using the installers (no Python installed).

My question is the following: If the sqlite3 library is expected to have the executable, why don't we package it? Any ideas @madebr @SSE4 @uilianries ?

@danimtb I've submitted a PR to add sqlite3 CLI: #1004

Please @btashton take a look at the sqlite3 approach and try to use the sqlite3 executable from the Conan package now that we got #1004 merged. Thanks!

Looking at #1004, sqlite3 will fail when using as a build requirement and cross building (e.g. building an arm application on x86).

btashton · 2020-03-12T15:33:23Z

This is only a build time dependency on the executable since it is creating a database that it uses at runtime. In the past it looked like the sqlite utility was packaged up on its own to avoid this problem.

I also think I'm not storing the database in the standard place for the Conan package so I should also address that as well.

madebr · 2020-03-12T15:38:41Z

This is only a build time dependency on the executable since it is creating a database that it uses at runtime. In the past it looked like the sqlite utility was packaged up on its own to avoid this problem.

Then you should add it to the build_requirements method instead of requirements.

re: #751 (comment)
@danimtb @uilianries
What would you suggest? Until conan supports crossbuilding, using sqlite as a build requirement will fail.

SpaceIm · 2020-03-12T15:43:07Z

@madebr AFAIK, sqlite3 is both a requirements (proj depends on sqlite3) and a build_requirements (for the executable, in order to create proj.db).

btashton · 2020-03-12T15:52:05Z

@madebr AFAIK, sqlite3 is both a requirements (proj depends on sqlite3) and a build_requirements (for the executable, in order to create proj.db).

Exactly. This is also why I think my hack might be ok for now if we don't have a good solution. If they are building with Conan they have the python with sqlite and we don't have to deal with the cross build issue.

danimtb · 2020-03-23T17:21:23Z

Well, reading this again I understand that the cross-building case is not well covered with now with Conan. However, now that we have the sqlite3 executable packaged by the recipe, we should use it in this recipe to avoid the python hack. Some people might use Conan from the stand-alone installers and could not have python available.

Morever, I think that doing this hack is worse for the future fix of the cross-building case than having a clean recipe without misleading python hacks.

danimtb

Please address the changes regarding the squlite3 executable usage

SpaceIm · 2020-03-25T17:01:11Z

@btashton I'm close to provide a working PROJ recipe using sqlite3 executable (without python). I'll submit a PR to your branch.

I've also made several modifications:

add threadsafe option
dl removed from system libs (need to check on Linux, but I don't think dl is required)
PROJ_MSVC_DLL_IMPORT defined for consumer if shared and Visual Studio compiler
add path to executables in PATH env (maybe I can add options to disable building these exe, since PROJ provides option for them).
bump version of sqlite3
fix class name (ProjConan isntead of LibaecConan)
move proj.db in res folder (and update PROJ_LIB accordingly)

(I'm waiting for this recipe for libgeotiff and maybe for a first attempt to package gdal)

btashton · 2020-03-25T17:44:05Z

Great I'll set aside some time to take a look. Thanks for helping push it over the finish line I have had a bunch of other things on my plate.

SpaceIm · 2020-03-26T09:21:36Z

Done: btashton#1 ;)

SpaceIm · 2020-03-26T12:25:07Z

For the sake of memory:

PROJ < 7 exported target is PROJ4:proj
PROJ >=7 exported target is PROJ:proj (PROJ4:proj deprecated)

SpaceIm · 2020-04-02T09:12:47Z

@btashton @danimtb Would you mind if I submit a new PR for proj/6.3.0 based on https://github.com/SpaceIm/conan-center-index/tree/proj/fix-and-improvements (it includes btashton commits), so we can move forward easily?

danimtb · 2020-04-03T08:27:06Z

I'll let @btashton answer this. For me it ok whatever you both agree 😄

btashton · 2020-04-03T21:33:08Z

@SpaceIm If you want to take this across the finish line that would be great. Sorry I lost track of this in all my github notifications. If you ping me in your PR I would be happy to try and help with the review.

btashton · 2020-04-06T17:19:39Z

Closing in favor of #1272 Thanks @SpaceIm for finishing this up.

btashton force-pushed the proj branch from 96fb8a5 to b6f9a0c Compare January 30, 2020 07:33

conan-center-bot added the Failed label Jan 30, 2020

conan-center-bot removed the Failed label Jan 30, 2020

btashton force-pushed the proj branch from b6f9a0c to d2ee7a4 Compare January 30, 2020 07:55

conan-center-bot added the Failed label Jan 30, 2020

btashton force-pushed the proj branch from 1abdd97 to ca730f7 Compare January 30, 2020 08:39

btashton force-pushed the proj branch from ca730f7 to 0a67422 Compare January 30, 2020 09:05

btashton force-pushed the proj branch from 0a67422 to 24607b6 Compare January 30, 2020 09:44