- [mpir] enable M1 builds #8811
Conversation
Signed-off-by: SSE4 <tomskside@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
... love to see when a PR adds configurations 🚀 |
|
All green in build 2 (
|
| env_build = {"CC": tools.XCRun(self.settings).cc, | ||
| "CXX": tools.XCRun(self.settings).cxx} | ||
| if hasattr(self, "settings_build"): | ||
| # there is no CFLAGS_FOR_BUILD/CXXFLAGS_FOR_BUILD | ||
| xcrun = tools.XCRun(self.settings_build) | ||
| flags = " -Wno-implicit-function-declaration -isysroot {} -arch {}".format(xcrun.sdk_path, tools.to_apple_arch(self.settings_build.arch)) | ||
| env_build["CC_FOR_BUILD"] = xcrun.cc + flags | ||
| env_build["CXX_FOR_BUILD"] = xcrun.cxx + flags |
There was a problem hiding this comment.
Wouldn't it be more elegant and robust to get self._autotools.flags and self._autotools.cxxflags in _configure_autotools(), then inject those values + -Wno-implicit-function-declaration (likely for apple-clang >= 12) in CC_FOR_BUILD and CXX_FOR_BUILD if cross-building (I guess those values are required for some reason in this case instead of CFLAGS and CXXFLAGS)?
Indeed -isysroot <path> -arch <arch> is handled by AutoToolsBuildEnvironment AFAIK.
|
I detected other pull requests that are modifying mpir/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
closes: #8772
Specify library name and version: mpir/all
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.