Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpir: relocatable shared lib on macOS + modernize #9135

Merged
merged 6 commits into from
Feb 4, 2022
Merged

mpir: relocatable shared lib on macOS + modernize #9135

merged 6 commits into from
Feb 4, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 28, 2022

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@ghost ghost mentioned this pull request Jan 28, 2022
Closed
@ghost
Copy link

ghost commented Jan 28, 2022

I detected other pull requests that are modifying mpir/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@prince-chrismc prince-chrismc mentioned this pull request Jan 28, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
SpaceIm and others added 2 commits January 29, 2022 11:03
@SpaceIm @madebr
proper runtime mapping
6186e4a 
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
@SpaceIm
improve vc runtime handling
0ae986e
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
SSE4
SSE4 previously approved these changes Jan 30, 2022
View reviewed changes
@ghost ghost mentioned this pull request Feb 2, 2022
Merged
4 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm closed this Feb 2, 2022
@SpaceIm SpaceIm reopened this Feb 2, 2022
@conan-center-bot
Copy link
Collaborator

All green in build 5 (1f6d6ff34dffca0891e9dfc05acd1b42016af79b):

  • mpir/3.0.0@:
    All packages built successfully! (All logs)

@SpaceIm SpaceIm requested a review from SSE4 February 2, 2022 13:59
uilianries
uilianries approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit cb4b025 into conan-io:master Feb 4, 2022
@SpaceIm SpaceIm deleted the mpir-relocatable-macos branch February 4, 2022 09:34
@MatusKysel MatusKysel mentioned this pull request Feb 7, 2022
Merged
@SpaceIm SpaceIm mentioned this pull request Feb 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericLemanissier ericLemanissier ericLemanissier approved these changes

@madebr madebr madebr approved these changes

@uilianries uilianries uilianries approved these changes

@intelligide intelligide intelligide approved these changes

@SSE4 SSE4 Awaiting requested review from SSE4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@SpaceIm @conan-center-bot @SSE4 @ericLemanissier @madebr @uilianries @intelligide