Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opencascade: relocatable shared libs on macOS + bump requirements + modernize #8869

Merged
merged 4 commits into from
Feb 2, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 12, 2022

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@ghost
Copy link

ghost commented Jan 12, 2022

I detected other pull requests that are modifying opencascade/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@@ -428,11 +431,7 @@ def _register_components(modules_dict):
system_libs = target_deps.get("system_libs", [])
frameworks = target_deps.get("frameworks", [])

self.cpp_info.components[conan_component_target_name].names["cmake_find_package"] = target_lib
self.cpp_info.components[conan_component_target_name].names["cmake_find_package_multi"] = target_lib
self.cpp_info.components[conan_component_target_name].builddirs.append(self._cmake_module_subfolder)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@SpaceIm SpaceIm Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I guess because cmake file is in build_modules. And it's good, you don't want to add this folder to builddirs (because buildirsare prepended to CMAKE_MODULE_PATH in cmake generator, and we don't want consumer to be able to include this cmake file, it's an internal detail of cmake_find_package and cmake_find_package_multi generator).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@SpaceIm SpaceIm Jan 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, so it' just a warning now, but this hook is wrong, you don't have to put cmake files listed in build_modules, in builddirs as well.

From hook description:

It is only allowed to put build files in builddirs because the generators might be able to include them when needed, but only if they are located in well known paths.

No, generators use absolute path of the cmake file thanks to build_modules values, they don't need builddirs to append something in CMAKE_MODULE_PATH. builddirs is needed if you want to append something to CMAKE_MODULE_PATH in cmake or CMakeToolchain generators, that's all. Basically builddirs is for cmake module files which are packaged and may be included directly by consumers in their CMakeLists.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we first have to make this discussion in https://github.com/conan-io/hooks/, and fix the hooks, before spreading this all over CCI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 13, 2022

Process is terminated due to StackOverflowException.
Stack overflow
CMake Error: Generator: execution of make failed. Make command was: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/MSBuild/Current/Bin/MSBuild.exe ALL_BUILD.vcxproj /p:Configuration=Release /p:Platform=x64 /p:VisualStudioVersion=16.0 /v:m /m:16 /verbosity:minimal && 
opencascade/7.5.0: ERROR: Package '5997d823bb467a34be6ab792f04f405e6f67eeb1' build failed
opencascade/7.5.0: WARN: Build folder C:\J\w\BuildSingleReference@4/s\d2fcf1\1

damned

@SpaceIm SpaceIm closed this Jan 13, 2022
@SpaceIm SpaceIm reopened this Jan 13, 2022
@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm closed this Jan 13, 2022
@SpaceIm SpaceIm reopened this Jan 13, 2022
@SpaceIm SpaceIm closed this Jan 15, 2022
@SpaceIm SpaceIm reopened this Jan 15, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 18, 2022

This recipe is so hard to build in CI of CCI.

@SpaceIm SpaceIm reopened this Jan 27, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm closed this Jan 28, 2022
@SpaceIm SpaceIm reopened this Jan 28, 2022
@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm closed this Jan 28, 2022
@SpaceIm SpaceIm reopened this Jan 28, 2022
@SpaceIm SpaceIm closed this Jan 31, 2022
@SpaceIm SpaceIm reopened this Jan 31, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 28 (f0f5fe59e6c5162380dcca3ae9356d1551d0ffd0):

  • opencascade/7.6.0@:
    All packages built successfully! (All logs)

  • opencascade/7.5.0@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit efe7e9b into conan-io:master Feb 2, 2022
@SpaceIm SpaceIm deleted the opencascade-modernize branch February 2, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants