Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib: generate relocatable shared lib on macOS + drop 1.2.8 maintenance #9056

Merged
merged 3 commits into from
Feb 2, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 24, 2022

closes #9052


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@ghost
Copy link

ghost commented Jan 24, 2022

I detected other pull requests that are modifying zlib/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@SpaceIm SpaceIm changed the title zlib: generate relocatable shared lib zlib: generate relocatable shared lib + drop 1.2.8 maintenance Jan 24, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm changed the title zlib: generate relocatable shared lib + drop 1.2.8 maintenance zlib: generate relocatable shared lib on macOS + drop 1.2.8 maintenance Jan 25, 2022
@conan-center-bot
Copy link
Collaborator

All green in build 5 (826808593c68d2f29847c439e744119250a41760):

  • zlib/1.2.11@:
    All packages built successfully! (All logs)

Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I hope no sane person uses zlib 1.2.8 in 2022
  2. zlib is kinda foundational and vital (it's a dependency of almost everything) and we know it's sensitive for the name of the library produced (where it could be libz / libzlib / libzlibstatic / libzlibstaticd and o on). I'll try to check some additional configurations beside s that CCI provides (iOS/Android/MSYS/Cygwin/clang-cl etc)

@conan-center-bot conan-center-bot merged commit 8bc3d19 into conan-io:master Feb 2, 2022
@SpaceIm SpaceIm deleted the zlib-shared-relocatable branch February 2, 2022 16:45
@Samulus
Copy link

Samulus commented Feb 2, 2022

This just broke ZLIB for me (on CentOS7):

[cmake] ERROR: zlib/1.2.11: Error in build() method, line 77
[cmake] 	self._patch_sources()
[cmake] while calling '_patch_sources', line 56
[cmake] 	tools.patch(**patch)
[cmake] 	FileNotFoundError: [Errno 2] No such file or directory: 'patches/0003-cmake-fix-msys2-subsystem.patch'
[cmake] CMake Error at cmake/Conan.cmake:638 (message):
[cmake]   Conan install failed='1'
[cmake] Call Stack (most recent call first):
[cmake]   cmake/AddConanDependencies.cmake:132 (conan_cmake_install)
[cmake]   CMakeLists.txt:20 (include)

Regression or PEBKAC?

EDIT: Ah, I see you can pin to a specific hash. Using "zlib/1.2.11@#3c6672ce9417680324fc12c0768cb5af9e8ac90b" for anyone else who ran into this.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Feb 2, 2022

The issue is that your conan cache is corrupted (it seems that conandata.yml in export folder of zlib recipe in conan cache has not been updated on your machine, either a conan client issue or PEBKAC as you said). Remove zlib from your cache and install again, it should work.

@Samulus
Copy link

Samulus commented Feb 2, 2022

The issue is that your conan cache is corrupted (it seems that conandata.yml in export folder of zlib recipe in conan cache has not been updated on your machine, either a conan client issue or PEBKAC as you said). Remove zlib from your cache and install again, it should work.

Weird. I tried that multiple times (rm -rf ~/.conan/data/zlib) and it didn't work but now it does 🤷 thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants