- [embree3] fix clang-cl by converting resource to UTF-8 #9822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSE4
commented
Mar 17, 2022
| @@ -170,6 +170,13 @@ def _configure_cmake(self): | |||
| return self._cmake | |||
|
|
|||
| def build(self): | |||
| # some compilers (e.g. clang) do not like UTF-16 sources | |||
There was a problem hiding this comment.
for an additional safety, we may put it under if self.settings.compiler == "clang'. but I've checked, and Visual Studio builds just fine with it.
Signed-off-by: SSE4 <tomskside@gmail.com>
This comment has been minimized.
This comment has been minimized.
SSE4
commented
Mar 18, 2022
This comment has been minimized.
This comment has been minimized.
AndreyMlashkin
approved these changes
Mar 28, 2022
jgsogo
approved these changes
Mar 28, 2022
intelligide
approved these changes
Mar 28, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9808
Specify library name and version: embree3/all
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.