-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSBuild verbosity level #2575
Comments
I think this shouldn't go hardcoded in the recipe, if any, it should be something that could be configured in conan (maybe conan.conf?) so under different scenarios you can opt between different levels of verbosity. So in case something fails and you need to check, you don't need to modify the recipe, just the configuration. Also, I suggest increasing the log limits, those logs might eventually be useful if something goes wrong. We haven't had much feedback regarding issues with the log size, lets see if someone else has some feedback. |
I agree in general, but in the same time I think that
You actually never need this. That's why Visual Studio IDE uses verbosity:minimal by default - all compiler warning and errors are there without useless MSBuild self-diagnostic.
Well, you cannot control it - it's CI responsibility. I use Gitlab and it have 4Mb log size limit by default - quite enough, I think. If logs getting bigger (with normal verbosity/multiple builds they do), it should be fixed on the build level. |
Yes I agree, verbosity minimal could be a good default, and I think it is not breaking at all. What do you think that should be the user interface @lasote? An argument in conan.conf? Or maybe a |
I think it's a classic conan.conf/env var stuff. I think I'm ok reducing the default verbosity if you can increase it anytime to check something. I usually look the CL invocations to see if the flags are the expected ones. |
Yes, exactly, this is what I am thinking: I also inspect those messages often, so I would like an idiomatic way to set the verbose flag. Typically conan.conf is not very convenient for something that is switched on/off often, so the syntax then would be?
Maybe also it should be left as-is (verbose) as default, so users can easily inspect output, and being less verbose can be always easily set in CI. Not sure what would be the preferred approached by users. |
I like the ability to pass it as a command line arg. My only concern with what you have above is that this is not accepted by the |
Hi @kkas, It is not accepted by |
When building Visual Studio projects via CMake.build() or build_sln_command() default MSBuild verbosity level (normal) is used. It's quite noisy and for big libraries quickly exceeds any CI log size limits. I would like to have a way to control it. Right now I use (not very elegant)
but I think it's worth conan support. Something like
cmake = CMake(self, verbosity="quiet")
which adds-- /verbosity:quiet
to cmake command line.BTW,
/verbosity:minimal
seems to be more appropriate default value for CMake build helper (at least Visual Studio IDE thinks so)The text was updated successfully, but these errors were encountered: