Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : allow to specify MSBuild verbosity level #4251

Merged
merged 5 commits into from Jan 16, 2019

Conversation

Projects
None yet
4 participants
@SSE4
Copy link
Contributor

commented Jan 8, 2019

closes #2575

Changelog: Feature: allow to specify MSBuild verbosity level
Docs: conan-io/docs#1012

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@ghost ghost assigned SSE4 Jan 8, 2019

@ghost ghost added the stage: review label Jan 8, 2019

@SSE4 SSE4 changed the title - allow to specify MSBuild verbosity level Feature : allow to specify MSBuild verbosity level Jan 8, 2019

@lasote lasote added this to the 1.12 milestone Jan 9, 2019

@lasote lasote requested a review from danimtb Jan 9, 2019

Show resolved Hide resolved conans/client/build/cmake.py
Show resolved Hide resolved conans/client/build/msbuild.py
Show resolved Hide resolved conans/client/conf/__init__.py Outdated
Show resolved Hide resolved conans/client/tools/win.py
Show resolved Hide resolved conans/test/unittests/util/build_sln_command_test.py Outdated
@danimtb

This comment has been minimized.

Copy link
Member

commented Jan 9, 2019

Remember to include a PR to the changes in docs and to include a changelog entry in the description of this PR

SSE4 added some commits Jan 8, 2019

- allow to specify MSBuild verbosity level
Signed-off-by: SSE4 <tomskside@gmail.com>
- use None by default as CONAN_MSBUILD_VERBOSITY
Signed-off-by: SSE4 <tomskside@gmail.com>
- use MSBuild in tests
Signed-off-by: SSE4 <tomskside@gmail.com>
- add test for CMake helper and MSBuild verbosity
Signed-off-by: SSE4 <tomskside@gmail.com>

@SSE4 SSE4 force-pushed the SSE4:msbuild_verbosity branch from 9004962 to e9f2b8c Jan 13, 2019

@SSE4 SSE4 referenced this pull request Jan 13, 2019

Merged

- document MSBuild verbosity #1012

@SSE4

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2019

added docs

@ghost ghost assigned memsharded Jan 16, 2019

@memsharded memsharded merged commit af6b4cb into conan-io:develop Jan 16, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Jan 16, 2019

@danimtb danimtb referenced this pull request Jan 16, 2019

Merged

Fix develop testsuite: MSBuild verbosity level #4320

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.