Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] cmake_find_package generated file doesnt honor CONAN_CMAKE_SILENT_OUTPUT #6671

Closed
rasjani opened this issue Mar 12, 2020 · 1 comment · Fixed by #6672
Closed

[bug] cmake_find_package generated file doesnt honor CONAN_CMAKE_SILENT_OUTPUT #6671

rasjani opened this issue Mar 12, 2020 · 1 comment · Fixed by #6672

Comments

@rasjani
Copy link
Contributor

rasjani commented Mar 12, 2020

Environment Details (include every applicable attribute)

  • Operating System+version: not applicable
  • Compiler+version: not applicable
  • Conan version: everything released
  • Python version: not applicable

Steps to reproduce (Include if Applicable)

with cmake-conan at least when issuing following command:

cmake -GNinja -DCONAN_CMAKE_SILENT_OUTPUT $buildpath

and having cmake_find_package generator enabled in conanfile or passed in to conan_cmake_run(), generated Find$package.cmake has a single message() call. Since the bug is essentially here:

https://github.com/conan-io/conan/blob/develop/conans/client/generators/cmake_find_package.py#L9

Same will most likely happen with calling conan install too..

When cmake 3.17 or never, these could be removed by filtering on the log level but that is not option for everybody.

Logs (Executed commands with output) (Include/Attach if Applicable)

Excessive output like this will be shown when generating build scripts:

-- Conan: Using autogenerated FindYYY.cmake
-- Conan: Using autogenerated FindZZZ.cmake
rasjani pushed a commit to rasjani/conan that referenced this issue Mar 12, 2020
When CONAN_CMAKE_SILENT_OUTPUT is defined, generated Find$package.cmake
files should honour that.

Fixes conan-io#6671
@memsharded memsharded added this to the 1.24 milestone Mar 12, 2020
@jgsogo
Copy link
Contributor

jgsogo commented Mar 12, 2020

Hi, @rasjani Thanks for reporting and thanks for submitting the PR, I agree with you that all the output generated by Conan should be silenced by CONAN_CMAKE_SILENT_OUTPUT variable.

jgsogo pushed a commit that referenced this issue Mar 12, 2020
When CONAN_CMAKE_SILENT_OUTPUT is defined, generated Find$package.cmake
files should honour that.

Fixes #6671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants