Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use conan_message() instead of message() #6672

Merged
merged 1 commit into from Mar 12, 2020
Merged

Use conan_message() instead of message() #6672

merged 1 commit into from Mar 12, 2020

Conversation

rasjani
Copy link
Contributor

@rasjani rasjani commented Mar 12, 2020 •
edited by czoido

Changelog: Bugfix: Silent output from cmake_find_package generator with CONAN_CMAKE_SILENT_OUTPUT.
Docs: Omit

Fixes #6671

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Ps. docs not applicable .. but i did check the last box..

Use conan_message() instead of message()
26e0f72 
When CONAN_CMAKE_SILENT_OUTPUT is defined, generated Find$package.cmake
files should honour that.

Fixes conan-io#6671
@CLAassistant
Copy link

CLAassistant commented Mar 12, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@memsharded memsharded self-assigned this Mar 12, 2020
@memsharded memsharded added this to the 1.24 milestone Mar 12, 2020
@memsharded memsharded assigned jgsogo and unassigned memsharded Mar 12, 2020
@jgsogo jgsogo merged commit d70e041 into conan-io:develop Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgsogo jgsogo jgsogo approved these changes

@memsharded memsharded memsharded approved these changes

Assignees

@jgsogo jgsogo

Labels
None yet
Projects
None yet
Milestone
1.24
Development

Successfully merging this pull request may close these issues.

[bug] cmake_find_package generated file doesnt honor CONAN_CMAKE_SILENT_OUTPUT
4 participants
@rasjani @CLAassistant @jgsogo @memsharded