[bug] Automated config update exception needed for conan config install commands to prevent catch-22

[michaelmaguire]

Relates to the feature discussed in #7282

I think I just ran into a bug with this.

I had made a personal fork of our teams config to test out making this change, and used it to set up my own client with:

conan config install git@bbgithub.dev.mycorp.com:mmaguir1/conan_common_config_install.git --type git

I tested that, it worked fine, I got approval and landed the PR on our team's repo, and deleted my fork.

Today I went to perform a conan operation, which failed because the fork no longer exists.

So I thought, "no problem" I'll just re-set up my config to be from my team's repo:

C:\dev\src\PORT\pract>conan config install git@bbgithub.dev.mycorp.com:team/conan_common_config_install.git --type git
Trying to clone repo: git@bbgithub.dev.mycorp.com:mmaguir1/conan_common_config_install.git
ERROR: Can't clone repo: Command 'git -c http.sslVerify=true clone "git@bbgithub.dev.mycorp.com:mmaguir1/conan_common_config_install.git" .   ' returned non-zero exit status 128.
Cloning into '.'...
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

It now won't let me fix the problem, because before the new config install location can be set, it tries to check the old, non-existent location and errors out.

Of course I worked around this, but can we please add an exception to the automated scheduler checks for conan config install commands themselves?

[memsharded]

Hi @michaelmaguire

We added to Conan 1.27 two commands:

conan config install --list
conan config install --remove=index

To be able to remove configurations you don't want anymore. Would they solve the issue? What we didn't want to add is to quiet or silently pass over missing configuration origins. That should be an error and that should raise, then Conan provide the tool to manage the conan config install origins more easily.

What is not clear is why when you do conan config install <repo> it will call the other. Was it an auto-scheduled call?

[michaelmaguire]

Yes, there was an auto scheduled config due.

I can't make any more conan calls without it trying to check for updates from the old, non-existent location.

[memsharded]

Ok, I see what is happening.

You should at least be able to conan config install --list and then remove the conan config install --remove=index offending/non-existing origin. That will not try to launch the auto-scheduled call.

However, for cases where it fails (for example, no internet connection), it is likely that users don't want to remove the origins. So most likely, the scheduled task should always succeed in the sense that it update the timestamp, and wait for next scheduled call. What do you think @uilianries? I'd say to improve this for next release.

[michaelmaguire]

it is likely that users don't want to remove the origins

In this case, the command I was trying to run was to sent a new origin, which I was unable to do.

conan config install git@bbgithub.dev.mycorp.com:team/conan_common_config_install.git --type git

It seems like there should be an exception to the update check for the conan config install command.

I updated to 1.27, and it still suffers from this catch-22:

C:\dev\src>conan --version
Conan version 1.27.0

C:\dev\src>conan config install --list
Trying to clone repo: git@bbgithub.dev.mycorp.com:mmaguir1/conan_common_config_install.git
ERROR: Failed conan config install: Can't clone repo: Command 'git -c http.sslVerify=true clone "git@bbgithub.dev.mycorp.com:mmaguir1/conan_common_config_install.git" .   ' returned non-zero exit status 128.
Cloning into '.'...
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

C:\dev\src>conan config install git@bbgithub.dev.mycorp.com:nx/conan_common_config_install.git --type git
Trying to clone repo: git@bbgithub.dev.mycorp.com:mmaguir1/conan_common_config_install.git
ERROR: Failed conan config install: Can't clone repo: Command 'git -c http.sslVerify=true clone "git@bbgithub.dev.mycorp.com:mmaguir1/conan_common_config_install.git" .   ' returned non-zero exit status 128.
Cloning into '.'...
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

It's very easy to repro -- just fork your config repo, set config_install_interval = 1m, then conan config install it. Wait a minute and delete your fork. The only way to work around is to re-fork.

[memsharded]

Thanks for the detailed report. You are right, this is a completely a bug, needs to be fixed. Please @uilianries have a look.

[michaelmaguire]

No worries. It's a nice feature. You want to make an omelette, you need to break a few eggs.

[uilianries]

@memsharded Not only this problem, but if there is no config listed in the index we will have a problem. I think we should put a warning, and ignore the error.

[czoido]

Merged the fix, will be release in 1.28

[michaelmaguire]

I upgraded to v 1.28.1 and can confirm this is fixed for me now. Thanks!

[memsharded]

I upgraded to v 1.28.1 and can confirm this is fixed for me now. Thanks!

Great, thanks for checking it and reporting @michaelmaguire!

[michaelmaguire]

Note:

Don't forget after testing this to use conan config install --list and if necessary conan config install --remove=1 or conan config init --force to clean up your config.