fix not finding the Premake executable #10250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
reviewed
Dec 30, 2021
| @@ -109,7 +109,13 @@ | |||
| "system": {"path": {'Windows': 'C:/bazel/bin', | |||
| "Darwin": '/Users/jenkins/bin'}}, | |||
| }, | |||
| 'premake': {}, | |||
| 'premake': { | |||
There was a problem hiding this comment.
This will not work in our CI once you start using premake with pytest.mark.tool_premake in any test, because our CI agents will not have premake installed. We should do:
- Put it in the comments sections of this file, for reference
- Move it to your own
conftest_user.pyso it works for you locally. - Add
pytest.mark.tool_premaketo the test - Keep the
disabledin the conftest.py until we add it to CI - We will ask @davidsanfal if they can put premake5 in our CI builders, and report on the location
|
Merging this, but this will fail when tests add the |
memsharded
added a commit
to memsharded/conan
that referenced
this pull request
Feb 28, 2022
Co-authored-by: James <james@conan.io>
memsharded
added a commit
that referenced
this pull request
Mar 1, 2022
* proposing base_source_folder, and folders.root * Update conans/model/layout.py Co-authored-by: Luis Martinez <lasote@gmail.com> * [feature] `ConfDefinition` and `Conf` enhancements. (#10537) * first approach. Big changes in Conf * Fixing errors * Fixing more tests * Deleted useless iteration * All the tests passing * Testing * Added items method * fixed rebased * Keeping old functions for backward compatibility * backward compatibility * Keeping indentation * Ordering methods and improved legacy logic * Added fixme * Reverted breaking changes * Added more complete test * Added more access Conf tests * Added docstring * Splitted string asserts * Added get/pop functions * Breaking refactor. Trying new structure * fixing tests * Changing tests * Fixed tests * Fixed Python 2.x problems * Removed useless layer of types * Fixed py2 * Fixed errors and added cast param to apply function to convert any type * Added TODO * Improved docstring * Fixed error * Update conans/model/conf.py Co-authored-by: James <james@conan.io> * Update conans/model/conf.py Co-authored-by: James <james@conan.io> * Added check_type and removed cast * Changed main structure. Now simpler and more powerful * Explicit default * Fixed error * Simplified compile options * Changed all the legacy conf getitem built-ins * Fixed test * Fixed bad type * Added more tests * More tests * Fix test for Python2 * Added more tests. Fixed corner-cases * Added one cli test and improved boolean conf UX * Moved str conveersion * Added one more mechanism to other smart conversion. Added more tests * Removed useless OR Co-authored-by: James <james@conan.io> * [PkgConfigDeps] Added new property `component_version` (#10633) * Added custom versions and descriptions for components * Changed property to component_version. Backported to legacy PkgConfig * package_folder available when "conan install" consumer (#10655) * WIP: Test failing * output_folder absolute only when existing * Fix test windows * added a few conf checkers (#10656) * Use absolute paths in conanbuild.sh (#10653) * use absolute path * Update conans/test/integration/environment/test_env.py Co-authored-by: James <james@conan.io> * fix tests * fix test * fix win * fix win Co-authored-by: James <james@conan.io> * Cleanup tmpdirs (#10663) * refactor toolchain (#10665) * fix not finding the Premake executable (#10250) Co-authored-by: James <james@conan.io> * review Co-authored-by: Luis Martinez <lasote@gmail.com> Co-authored-by: Francisco Ramírez <franchuti688@gmail.com> Co-authored-by: Carlos Zoido <mrgalleta@gmail.com> Co-authored-by: Enhex <enhex0@gmail.com>
memsharded
added a commit
that referenced
this pull request
Mar 2, 2022
* introducing modern conan.tool.scm.Git helper * skip Py2, change git config order * wip * wip * wip * wip * let conandata_update create conandata.yml if not exist * full SCM test * adding monorepo case * fix test * fix test * fix tests * fix test * add subfolder test * proposing base_source_folder, and folders.root * Update conans/model/layout.py Co-authored-by: Luis Martinez <lasote@gmail.com> * [feature] `ConfDefinition` and `Conf` enhancements. (#10537) * first approach. Big changes in Conf * Fixing errors * Fixing more tests * Deleted useless iteration * All the tests passing * Testing * Added items method * fixed rebased * Keeping old functions for backward compatibility * backward compatibility * Keeping indentation * Ordering methods and improved legacy logic * Added fixme * Reverted breaking changes * Added more complete test * Added more access Conf tests * Added docstring * Splitted string asserts * Added get/pop functions * Breaking refactor. Trying new structure * fixing tests * Changing tests * Fixed tests * Fixed Python 2.x problems * Removed useless layer of types * Fixed py2 * Fixed errors and added cast param to apply function to convert any type * Added TODO * Improved docstring * Fixed error * Update conans/model/conf.py Co-authored-by: James <james@conan.io> * Update conans/model/conf.py Co-authored-by: James <james@conan.io> * Added check_type and removed cast * Changed main structure. Now simpler and more powerful * Explicit default * Fixed error * Simplified compile options * Changed all the legacy conf getitem built-ins * Fixed test * Fixed bad type * Added more tests * More tests * Fix test for Python2 * Added more tests. Fixed corner-cases * Added one cli test and improved boolean conf UX * Moved str conveersion * Added one more mechanism to other smart conversion. Added more tests * Removed useless OR Co-authored-by: James <james@conan.io> * [PkgConfigDeps] Added new property `component_version` (#10633) * Added custom versions and descriptions for components * Changed property to component_version. Backported to legacy PkgConfig * package_folder available when "conan install" consumer (#10655) * WIP: Test failing * output_folder absolute only when existing * Fix test windows * added a few conf checkers (#10656) * Use absolute paths in conanbuild.sh (#10653) * use absolute path * Update conans/test/integration/environment/test_env.py Co-authored-by: James <james@conan.io> * fix tests * fix test * fix win * fix win Co-authored-by: James <james@conan.io> * Cleanup tmpdirs (#10663) * refactor toolchain (#10665) * fix not finding the Premake executable (#10250) Co-authored-by: James <james@conan.io> * review * wip * simplified tests * new branch test * review * fix test Co-authored-by: Luis Martinez <lasote@gmail.com> Co-authored-by: Francisco Ramírez <franchuti688@gmail.com> Co-authored-by: Carlos Zoido <mrgalleta@gmail.com> Co-authored-by: Enhex <enhex0@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Fix Premake test failing on Linux because the Premake executable isn't found.
Docs: omit
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.
relevant issue: #10234