proposing base_source_folder, and folders.root #10654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
approved these changes
Feb 24, 2022
conans/model/layout.py
Outdated
|
|
||
| def __repr__(self): | ||
| return str(self.__dict__) | ||
|
|
||
| def set_local(self, conanfile_folder, output_folder): |
There was a problem hiding this comment.
maybe set_base_folders? I don't know why set_local
There was a problem hiding this comment.
Also a docstring would be nice. It is not easy to understand the arguments and the sense they have.
There was a problem hiding this comment.
This is only called from local flow, never in the cache. I tried to convey that meaning. I can try to rename to something like set_local_base_folders() and I will add docstring.
There was a problem hiding this comment.
I don't know if "from where I call it" should be the thing naming the function rather than the thing that the function does.
There was a problem hiding this comment.
Renamed the method, and added a bunch of docstrings and comments in b6971ba, please re-review and let me know
Co-authored-by: Luis Martinez <lasote@gmail.com>
* first approach. Big changes in Conf * Fixing errors * Fixing more tests * Deleted useless iteration * All the tests passing * Testing * Added items method * fixed rebased * Keeping old functions for backward compatibility * backward compatibility * Keeping indentation * Ordering methods and improved legacy logic * Added fixme * Reverted breaking changes * Added more complete test * Added more access Conf tests * Added docstring * Splitted string asserts * Added get/pop functions * Breaking refactor. Trying new structure * fixing tests * Changing tests * Fixed tests * Fixed Python 2.x problems * Removed useless layer of types * Fixed py2 * Fixed errors and added cast param to apply function to convert any type * Added TODO * Improved docstring * Fixed error * Update conans/model/conf.py Co-authored-by: James <james@conan.io> * Update conans/model/conf.py Co-authored-by: James <james@conan.io> * Added check_type and removed cast * Changed main structure. Now simpler and more powerful * Explicit default * Fixed error * Simplified compile options * Changed all the legacy conf getitem built-ins * Fixed test * Fixed bad type * Added more tests * More tests * Fix test for Python2 * Added more tests. Fixed corner-cases * Added one cli test and improved boolean conf UX * Moved str conveersion * Added one more mechanism to other smart conversion. Added more tests * Removed useless OR Co-authored-by: James <james@conan.io>
* Added custom versions and descriptions for components * Changed property to component_version. Backported to legacy PkgConfig
* WIP: Test failing * output_folder absolute only when existing * Fix test windows
* use absolute path * Update conans/test/integration/environment/test_env.py Co-authored-by: James <james@conan.io> * fix tests * fix test * fix win * fix win Co-authored-by: James <james@conan.io>
Co-authored-by: James <james@conan.io>
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Adding
self.base_source_folderforexports_sourcesexplicit layouts.Changelog: Feature: Adding
rootto layout model to allow conanfile.py in subfolders.Docs: conan-io/docs#2418