Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature][PkgConfigDeps] Warn about duplicated *.pc names #10263

Merged

Conversation

franramirez688
Copy link
Contributor

@franramirez688 franramirez688 commented Jan 3, 2022

Changelog: Feature: PkgConfigDeps shows WARN messages if there are duplicated pkg_config_name and/or pkg_config_aliases.
Docs: conan-io/docs#2378
Closes #10226

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, maybe a bit of repetition in the warn msg that could be refactored later, but good atm.

@memsharded memsharded assigned czoido and unassigned memsharded Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature][PkgConfigDeps] Warn duplicated *.pc names (using pkg_config_name)
3 participants