[PkgConfigDeps] Creates *.pc files for test_requires
#11390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSE4
reviewed
Jun 3, 2022
| for _, dep in host_req.items(): | ||
| build_req = self._conanfile.dependencies.direct_build | ||
| test_req = self._conanfile.dependencies.test | ||
| for _, dep in list(host_req.items()) + list(build_req.items()) + list(test_req.items()): |
There was a problem hiding this comment.
is there any risk of pkg-config files from different contexts overriding each other? like build_requiries(protobuf) + requires(protobuf)
There was a problem hiding this comment.
Yes, but that's a problem that you could even have with other components. Have a look at this PR #10263 So, you should change that pkg_config_name/pkg_config_aliases property.
memsharded
requested changes
Jun 3, 2022
franramirez688
commented
Jun 3, 2022
| assert "Requires: OpenCL" in get_requires_from_content(pc_content) | ||
|
|
||
|
|
||
| def test_pkgconfigdeps_with_test_requires(): |
There was a problem hiding this comment.
@memsharded This is the new one. The rest of the diff is only a code movement.
memsharded
approved these changes
Jun 3, 2022
franramirez688
changed the title
*.pc files for build_requires and test_requires*.pc files for test_requires
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix:
PkgConfigDepscreates*.pcfiles fortest_requires.Docs: omit
Closes: #11376