Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 11150 #11330

Merged
merged 5 commits into from
May 25, 2022
Merged

Feature/issue 11150 #11330

merged 5 commits into from
May 25, 2022

Conversation

lasote
Copy link
Contributor

@lasote lasote commented May 25, 2022

Changelog: Feature: Remove the parameter copy_symlink_folders of the conan.tool.files.copy function and now, any symlink file pointing to a folder will be treated as a regular file.
Docs: conan-io/docs#2558

Now, any symlink file pointing to a folder will be treated as a regular file, so they will only be copied if the specified pattern matches with the file. At the destination folder, it will be created pointing to the exact same folder (absolute or relative) being the user's responsibility (if necessary) to make the symlink a relative path before copying it.

Close #11150

@lasote lasote requested a review from memsharded May 25, 2022 13:46
@lasote lasote added this to the 1.49 milestone May 25, 2022
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. The test is broken in 2.7: from pathlib import Path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Remove or change copy_symlink_folders in conan.tools.files.copy
2 participants