Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config container name for Docker runner #16243

Merged
merged 1 commit into from
May 13, 2024
Merged

Fix config container name for Docker runner #16243

merged 1 commit into from
May 13, 2024

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented May 13, 2024 •
edited by czoido

This PR uses the configuration attribute run.name instead of the Docker image name.

Added tests to validate both default container and custom container name.

fixes #16234

Changelog: Fix: Fix config container name for Docker runner.
Docs: Omit

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@uilianries
fix docker container name usage
8160141 
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@memsharded memsharded added this to the 2.3.1 milestone May 13, 2024
@czoido czoido merged commit 4192b14 into conan-io:release/2.3 May 13, 2024
2 checks passed
@memsharded memsharded mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czoido czoido czoido approved these changes

@RubenRBS RubenRBS RubenRBS approved these changes

@memsharded memsharded memsharded approved these changes

@davidsanfal davidsanfal Awaiting requested review from davidsanfal

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uilianries @czoido @RubenRBS @memsharded