Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow info access in source() method #16272

Merged
merged 3 commits into from
May 16, 2024

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented May 16, 2024

Changelog: Bugfix: Disallow self.info access in source() method.
Docs: Omit

As mentioned in #15666, self.info access in the source() method was a leak - it was not intended to be used inside said method, and accesses to the attribute were a bug by design, as the source method must not rely on configuration values to change its behaviour

Also adds some more beloved light=True in this file for those tests that pass with it

@AbrilRBS AbrilRBS added this to the 2.4.0 milestone May 16, 2024
@memsharded memsharded merged commit e5b1278 into conan-io:develop2 May 16, 2024
2 checks passed
@AbrilRBS AbrilRBS deleted the rr/info-source-disallow branch May 16, 2024 08:57
gregmedd added a commit to gregmedd/up-cpp that referenced this pull request Jun 5, 2024
Conan 3.4.0 was released today, and it fixed some bugs that we were
using in our recipes. See conan-io/conan#16272

Additionally, the old way of passing the conan cache was brittle, so it
has been switched to an artifact.

Lastly, a fixed conan profile is set to reduce the risk of changes
breaking things.
gregmedd added a commit to gregmedd/up-cpp that referenced this pull request Jun 5, 2024
Conan 3.4.0 was released today, and it fixed some bugs that we were
using in our recipes. See conan-io/conan#16272

Additionally, the old way of passing the conan cache was brittle, so it
has been switched to an artifact.

Lastly, a fixed conan profile is set to reduce the risk of changes
breaking things.
BishrutSubedi pushed a commit to BishrutSubedi/up-cpp that referenced this pull request Jun 7, 2024
Conan 3.4.0 was released today, and it fixed some bugs that we were
using in our recipes. See conan-io/conan#16272

Additionally, the old way of passing the conan cache was brittle, so it
has been switched to an artifact.

Lastly, a fixed conan profile is set to reduce the risk of changes
breaking things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants