Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ask for username if it is already given #3839

Merged
merged 3 commits into from Oct 24, 2018

Conversation

Projects
None yet
3 participants
@jgsogo
Copy link
Member

commented Oct 24, 2018

Changelog: Bugfix: do not ask for the username if it is already given when login into a remote.

These lines were modified in this PR #3464 to v1.8, and the previous behavior altered.

@jgsogo jgsogo added this to the 1.9 milestone Oct 24, 2018

@jgsogo jgsogo requested a review from memsharded Oct 24, 2018

@ghost ghost assigned jgsogo Oct 24, 2018

@ghost ghost added the stage: review label Oct 24, 2018

@danimtb

This comment has been minimized.

Copy link
Member

commented Oct 24, 2018

I was thinking about this and previous PR introduced some tests that are passing now, so maybe this was not covered by them. Is it possible to include something testing this @jgsogo?

@jgsogo

This comment has been minimized.

Copy link
Member Author

commented Oct 24, 2018

Here you have your test ;D

@danimtb danimtb assigned memsharded and unassigned jgsogo and danimtb Oct 24, 2018

@memsharded memsharded merged commit d9a75ef into conan-io:develop Oct 24, 2018

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Oct 24, 2018

@jgsogo jgsogo deleted the jgsogo:issue/3800-username-login branch Oct 25, 2018

grisumbras pushed a commit to grisumbras/conan that referenced this pull request Dec 27, 2018

Merge pull request conan-io#3839 from jgsogo/issue/3800-username-login
Do not ask for username if it is already given
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.