Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove credentials from 'url' for SCM replacement #4207

Merged
merged 3 commits into from Jan 2, 2019
Merged

Remove credentials from 'url' for SCM replacement #4207

merged 3 commits into from Jan 2, 2019

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Dec 28, 2018 •
edited

Changelog: Fix: Credentials are removed from SCM url attribute if Conan is automatically resolving it.
Docs: conan-io/docs#996

@ghost ghost assigned jgsogo Dec 28, 2018
@ghost ghost added the stage: review label Dec 28, 2018
@jgsogo jgsogo mentioned this pull request Dec 28, 2018
Merged
memsharded
memsharded approved these changes Dec 28, 2018
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good too me. Good implementation, clear, well tested. Good job.

@memsharded memsharded assigned lasote and unassigned jgsogo Dec 28, 2018
@memsharded memsharded added this to the 1.12 milestone Dec 28, 2018
@lasote lasote merged commit 45eac22 into conan-io:develop Jan 2, 2019
@ghost ghost removed the stage: review label Jan 2, 2019
@jgsogo jgsogo deleted the issue/4001-remove-credentials-from-scm-url branch January 2, 2019 11:30
NoWiseMan pushed a commit to NoWiseMan/conan that referenced this pull request Jan 9, 2019
@jgsogo @NoWiseMan
Remove credentials from 'url' for SCM replacement (conan-io#4207)
3da7780 
* add 'remove_credentials' argument to SCMBase.get_remote_url

* modify comments

* do not remove credentials if it is a local path
@jasal82 jasal82 mentioned this pull request Aug 9, 2019
Closed
@wizardsd wizardsd mentioned this pull request Sep 27, 2019
Closed
3 tasks
@GordonJess GordonJess mentioned this pull request Jan 31, 2020
Closed
@wizardsd wizardsd mentioned this pull request Aug 5, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees

@lasote lasote

Labels
None yet
Projects
None yet
Milestone
1.12
Development

Successfully merging this pull request may close these issues.

scm "url" = "auto" vs GitLab CI runner
3 participants
@jgsogo @memsharded @lasote