Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove credentials from 'url' for SCM replacement #4207

Merged

Conversation

Projects
None yet
3 participants
@jgsogo
Copy link
Member

commented Dec 28, 2018

Changelog: Fix: Credentials are removed from SCM url attribute if Conan is automatically resolving it.
Docs: conan-io/docs#996

  • closes #4001
  • add docs noticing this change.

@ghost ghost assigned jgsogo Dec 28, 2018

@ghost ghost added the stage: review label Dec 28, 2018

@memsharded
Copy link
Contributor

left a comment

Looks good too me. Good implementation, clear, well tested. Good job.

@memsharded memsharded assigned lasote and unassigned jgsogo Dec 28, 2018

@memsharded memsharded added this to the 1.12 milestone Dec 28, 2018

@lasote lasote merged commit 45eac22 into conan-io:develop Jan 2, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Jan 2, 2019

@jgsogo jgsogo deleted the jgsogo:issue/4001-remove-credentials-from-scm-url branch Jan 2, 2019

NoWiseMan added a commit to NoWiseMan/conan that referenced this pull request Jan 9, 2019

Remove credentials from 'url' for SCM replacement (conan-io#4207)
* add 'remove_credentials' argument to SCMBase.get_remote_url

* modify comments

* do not remove credentials if it is a local path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.