Adds support of URL-like git ssh syntax #7509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tocols git supports two kinds of addresses, URL-like: ssh://[user@]server/project.git and scp-like: [user@]server:project.git This fix adds support of URL-like addresses
|
|
memsharded
approved these changes
Aug 5, 2020
jgsogo
suggested changes
Aug 10, 2020
| # URL-like syntax | ||
| self.assertEqual('ssh://git@github.com:2222/conan-io/conan.git', | ||
| SCMBase._remove_credentials_url( | ||
| 'ssh://git@github.com:2222/conan-io/conan.git')) |
There was a problem hiding this comment.
Add a test to check that we are actually removing the password:
self.assertEqual('ssh://git@github.com:2222/conan-io/conan.git',
SCMBase._remove_credentials_url(
'ssh://git:passwd@github.com:2222/conan-io/conan.git'))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Adds support of URL-like git ssh syntax.
Docs: omit
This PR fixes adds support of URL-like addresses mentioned #5833 (as for me, it was a regression introduced in #4207)
According to https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols git supports two kinds of addresses, URL-like: ssh://[user@]server/project.git and scp-like: [user@]server:project.git
developbranch, documenting this one.#PYVERS: Macos@py27, Windows@py36, Linux@py27
closes #5833