Remove double application of env vars from profile #4380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
danimtb
commented
Jan 25, 2019
| @unittest.skipUnless(platform.system() == "Windows", "Test both .sh and .bat files") | ||
| class VirtualenvGeneratorTest(unittest.TestCase): | ||
|
|
||
| def prepend_values_test(self): |
There was a problem hiding this comment.
This test checks that is not the fault of the virtualenv generator
|
Tried to make unit tests for this but I ended up with a lot of objects with values pre loaded just to test the loader methods... 🙄 So maybe it is better to add just a functional test for conanfile.txt and check the environment prepended values with the virtualenv generator output |
danimtb
changed the title
memsharded
requested changes
Jan 25, 2019
SSE4
reviewed
Jan 25, 2019
lasote
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: BugFix: Prepend environment variables are applied twice in conanfile
Docs: omit
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.