Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase Workspaces on Editable packages #4481

Merged
merged 47 commits into from Feb 26, 2019
Merged

Rebase Workspaces on Editable packages #4481

merged 47 commits into from Feb 26, 2019

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Feb 6, 2019 •
edited by danimtb

Changelog: Feature: Re-implement Workspaces based on Editable packages.
Changelog: Fix: Renamed the conan link command to conan editable to put packages into editable mode.
Docs: conan-io/docs#1086

Close #3408
Close #3274
Close #3145
Close #3141
Close #3306
Close #4558
Close #4397
Close #4009
Close #3403
Close #4422
Close #1377

Open issues:

@ghost ghost assigned memsharded Feb 6, 2019
@ghost ghost added the stage: review label Feb 6, 2019
@jgsogo jgsogo mentioned this pull request Feb 8, 2019
Closed
@lasote
Copy link
Contributor

lasote commented Feb 11, 2019

Is this still a WIP?
(solve conflicts)

@memsharded memsharded changed the title WIP: Feature/rebasing ws Rebase Workspaces on Editable packages Feb 11, 2019
@memsharded
Copy link
Member Author

Ready for review.

This was referenced Feb 19, 2019
Closed
Closed
@memsharded memsharded mentioned this pull request Feb 19, 2019
Closed
5 tasks
@jgsogo jgsogo mentioned this pull request Feb 22, 2019
Merged
jgsogo
jgsogo reviewed Feb 25, 2019
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 A few comments, nothin really blocking.

conans/client/conan_api.py Outdated Show resolved Hide resolved
conans/client/cache/editable.py Outdated Show resolved Hide resolved
conans/client/installer.py Outdated Show resolved Hide resolved
conans/client/installer.py Outdated Show resolved Hide resolved
conans/model/workspace.py Outdated Show resolved Hide resolved
conans/model/workspace.py Outdated Show resolved Hide resolved
conans/model/workspace.py Show resolved Hide resolved
jgsogo
jgsogo approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got my 👍 !

lasote
lasote reviewed Feb 26, 2019
View reviewed changes
conans/model/workspace.py Outdated Show resolved Hide resolved
lasote
lasote reviewed Feb 26, 2019
View reviewed changes
conans/model/workspace.py Outdated Show resolved Hide resolved
lasote
lasote approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@lasote lasote left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Merge when CI passes

@memsharded memsharded merged commit 83053d0 into conan-io:develop Feb 26, 2019
@ghost ghost removed the stage: review label Feb 26, 2019
@memsharded memsharded deleted the feature/rebasing_ws branch February 26, 2019 14:10
@memsharded memsharded mentioned this pull request Feb 26, 2019
Closed
@memsharded memsharded moved this from In progress to Done in workspaces Feb 26, 2019
@memsharded memsharded mentioned this pull request Mar 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb requested changes

@jgsogo jgsogo jgsogo approved these changes

@lasote lasote lasote approved these changes

Assignees

@lasote lasote

@memsharded memsharded

Labels
None yet
Projects
workspaces
  
Done
Milestone
1.13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@memsharded @lasote @jgsogo @danimtb