Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase Workspaces on Editable packages #4481

Merged
merged 47 commits into from Feb 26, 2019

Conversation

Projects
4 participants
@memsharded
Copy link
Contributor

commented Feb 6, 2019

Changelog: Feature: Re-implement Workspaces based on Editable packages.
Changelog: Fix: Renamed the conan link command to conan editable to put packages into editable mode.
Docs: conan-io/docs#1086

Close #3408
Close #3274
Close #3145
Close #3141
Close #3306
Close #4558
Close #4397
Close #4009
Close #3403
Close #4422
Close #1377

Open issues:

@ghost ghost assigned memsharded Feb 6, 2019

@ghost ghost added the stage: review label Feb 6, 2019

memsharded added some commits Feb 6, 2019

@memsharded memsharded requested review from jgsogo, danimtb and lasote Feb 7, 2019

@lasote

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2019

Is this still a WIP?
(solve conflicts)

@memsharded memsharded changed the title WIP: Feature/rebasing ws Rebase Workspaces on Editable packages Feb 11, 2019

@memsharded

This comment has been minimized.

Copy link
Contributor Author

commented Feb 11, 2019

Ready for review.

@memsharded memsharded referenced this pull request Feb 19, 2019

Closed

feat(workspaces): generate conan-workspace.cmake #3404

4 of 5 tasks complete

@memsharded memsharded referenced this pull request Feb 19, 2019

Closed

Feature/workspace local detection #3462

5 of 5 tasks complete

memsharded added some commits Feb 22, 2019

@jgsogo
Copy link
Member

left a comment

👍 A few comments, nothin really blocking.

Show resolved Hide resolved conans/client/conan_api.py Outdated
Show resolved Hide resolved conans/client/cache/editable.py Outdated
Show resolved Hide resolved conans/client/installer.py Outdated
Show resolved Hide resolved conans/client/installer.py Outdated
Show resolved Hide resolved conans/model/workspace.py Outdated
Show resolved Hide resolved conans/model/workspace.py Outdated
Show resolved Hide resolved conans/model/workspace.py
@jgsogo

jgsogo approved these changes Feb 25, 2019

Copy link
Member

left a comment

Got my 👍 !

memsharded added some commits Feb 26, 2019

Show resolved Hide resolved conans/model/workspace.py Outdated
Show resolved Hide resolved conans/model/workspace.py Outdated
@lasote

lasote approved these changes Feb 26, 2019

Copy link
Contributor

left a comment

🎉 Merge when CI passes

@memsharded memsharded merged commit 83053d0 into conan-io:develop Feb 26, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Feb 26, 2019

@memsharded memsharded deleted the memsharded:feature/rebasing_ws branch Feb 26, 2019

@memsharded memsharded moved this from In progress to Done in workspaces Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.