Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4770 Do not force sudo when it is not found #4774

Merged

Conversation

Projects
None yet
2 participants
@uilianries
Copy link
Member

commented Mar 19, 2019

When CONAN_SYSREQUIRES_SUDO is not specified and sudo is not listed by tool.which, SystemPackageTools should not set sudo as prefix.

Changelog: Fix: SystemPackageTools doesn't run sudo when it's not found (#4470)
Docs: conan-io/docs#1127
fixes: #4770

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

#4770 Do not force sudo when it is not found
- When CONAN_SYSREQUIRES_SUDO is not specified and sudo is not listed
  by `which` command, SystemPackageTools should not set sudo.

Signed-off-by: Uilian Ries <uilianries@gmail.com>

@ghost ghost assigned uilianries Mar 19, 2019

@ghost ghost added the stage: review label Mar 19, 2019

@memsharded memsharded merged commit 0554ea8 into conan-io:develop Mar 19, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label Mar 19, 2019

@memsharded memsharded added this to the 1.14 milestone Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.