Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vs2019 when generator Ninja #5025

Merged
merged 2 commits into from Apr 25, 2019

Conversation

@DoDoENT
Copy link
Contributor

@DoDoENT DoDoENT commented Apr 24, 2019

Changelog: Bugfix: Fixed error while using Visual Studio 2019 with Ninja generator.
Docs: Omit

Close #4977

… about generator, as well as information about compiler
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Apr 24, 2019

CLA assistant check
All committers have signed the CLA.

@lasote lasote changed the title when determining whether generator contains platform, use information… Fix Vs2019 when generator Ninja Apr 25, 2019
@lasote lasote added this to the 1.14.4 milestone Apr 25, 2019
@lasote lasote mentioned this pull request Apr 25, 2019
@ghost ghost assigned lasote Apr 25, 2019
@ghost ghost added the stage: review label Apr 25, 2019
@lasote lasote removed this from the 1.14.4 milestone Apr 25, 2019
@memsharded memsharded merged commit f400033 into conan-io:release/1.14.4 Apr 25, 2019
1 of 2 checks passed
@ghost ghost removed the stage: review label Apr 25, 2019
@memsharded memsharded added this to the 1.14.4 milestone Apr 25, 2019
@DoDoENT DoDoENT deleted the fix/vs2019+ninja branch Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants