Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conan-io/hello example for the new command #5069

Merged
merged 4 commits into from May 3, 2019

Conversation

Projects
None yet
3 participants
@danimtb
Copy link
Member

commented Apr 30, 2019

Changelog: Feature: Updated the generated conanfile.py in conan new to the new [conan-io/hello].(https://github.com/conan-io/hello) repository
Docs: conan-io/docs#1269

  • Refer to the issue that supports this Pull Request: closes #4916
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@danimtb danimtb added this to the 1.15 milestone Apr 30, 2019

@ghost ghost assigned danimtb Apr 30, 2019

@ghost ghost added the stage: review label Apr 30, 2019

@jgsogo

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

There could be some places in the docs where we are using this conan new .... and then having a look at the generated conanfile.py... it could be confusing if the user calls the command and have a different generated conanfile (probably it's not so important)...

@danimtb danimtb removed their assignment Apr 30, 2019

@ghost ghost assigned danimtb Apr 30, 2019

@danimtb

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

I have included the changes in the documentation too

@danimtb danimtb removed their assignment Apr 30, 2019

@ghost ghost assigned danimtb Apr 30, 2019

@danimtb danimtb removed their assignment Apr 30, 2019

Show resolved Hide resolved conans/client/cmd/new.py Outdated
@@ -244,7 +244,7 @@ def build_local_different_folders_test(self):
install_dir = os.path.join(client.current_folder, "install_x86_64")
tools.replace_in_file(os.path.join(client.current_folder, "src", "hello", "CMakeLists.txt"),
"${CMAKE_BINARY_DIR}/conanbuildinfo.cmake",
'"%s/conanbuildinfo.cmake"' % install_dir,

This comment has been minimized.

Copy link
@memsharded

memsharded Apr 30, 2019

Contributor

why necessary? It is not failing so far

This comment has been minimized.

Copy link
@danimtb

danimtb Apr 30, 2019

Author Member

I was wondering the same and I have no idea...

This comment has been minimized.

Copy link
@jgsogo

jgsogo Apr 30, 2019

Member

It failed in this CI job, I would want to know what's happening, but if it is needed, this PR is ok for me and ready to merge.

@jgsogo

jgsogo approved these changes Apr 30, 2019

Copy link
Member

left a comment

LGTM, just remove the cd hello pointed out by memsharded.

Thanks!

@ghost ghost assigned danimtb Apr 30, 2019

@danimtb danimtb assigned memsharded and unassigned jgsogo and danimtb Apr 30, 2019

@memsharded memsharded merged commit 20b8dfa into conan-io:develop May 3, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@ghost ghost removed the stage: review label May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.