Use conan-io/hello example for the new command #5069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
There could be some places in the docs where we are using this |
|
I have included the changes in the documentation too |
memsharded
reviewed
Apr 30, 2019
| @@ -244,7 +244,7 @@ def build_local_different_folders_test(self): | |||
| install_dir = os.path.join(client.current_folder, "install_x86_64") | |||
| tools.replace_in_file(os.path.join(client.current_folder, "src", "hello", "CMakeLists.txt"), | |||
| "${CMAKE_BINARY_DIR}/conanbuildinfo.cmake", | |||
| '"%s/conanbuildinfo.cmake"' % install_dir, | |||
There was a problem hiding this comment.
why necessary? It is not failing so far
There was a problem hiding this comment.
I was wondering the same and I have no idea...
There was a problem hiding this comment.
It failed in this CI job, I would want to know what's happening, but if it is needed, this PR is ok for me and ready to merge.
jgsogo
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Updated the generated conanfile.py in
conan newto the new [conan-io/hello].(https://github.com/conan-io/hello) repositoryDocs: conan-io/docs#1269
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.