package ID modes taking into account revisions #5363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
reviewed
Jun 17, 2019
There was a problem hiding this comment.
Very nice. Some things to comment:
- I forgot why in the previous approach you did the recalculation of the packageID and why do you think it is no longer necessary.
- How does all this play with graph-locks?
- A detail: The value
Package_ID_unknowngets printed sometimes, for example in the info, I think we should improve the printer to print "Package ID unknown: Cannot be calculated" or similar.
I would like to move this to 1.17 if it can be kept as simple as it looks. (point 1)
lasote
approved these changes
Jun 21, 2019
memsharded
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Define 2 new modes and helpers for the package binary ID:
recipe_revision_modeandpackage_revision_mode, that take into account the revisions. The second one will use all the information from dependencies, resulting in fully deterministic and complete package IDs: if some dependency change, it will be necessary to build a new binary of consumersDocs: conan-io/docs#1345