Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package ID modes taking into account revisions #5363

Merged
merged 211 commits into from Jul 3, 2019

Conversation

Projects
None yet
2 participants
@memsharded
Copy link
Contributor

commented Jun 17, 2019

Changelog: Feature: Define 2 new modes and helpers for the package binary ID: recipe_revision_mode and package_revision_mode, that take into account the revisions. The second one will use all the information from dependencies, resulting in fully deterministic and complete package IDs: if some dependency change, it will be necessary to build a new binary of consumers
Docs: conan-io/docs#1345

@lasote
Copy link
Contributor

left a comment

Very nice. Some things to comment:

  1. I forgot why in the previous approach you did the recalculation of the packageID and why do you think it is no longer necessary.
  2. How does all this play with graph-locks?
  3. A detail: The value Package_ID_unknown gets printed sometimes, for example in the info, I think we should improve the printer to print "Package ID unknown: Cannot be calculated" or similar.

I would like to move this to 1.17 if it can be kept as simple as it looks. (point 1)

@lasote lasote added this to the 1.17 milestone Jun 17, 2019

@lasote

lasote approved these changes Jun 21, 2019

Copy link
Contributor

left a comment

Please submit docs and changelog and we can merge ASAP to integrate into the locks branch

@memsharded memsharded referenced this pull request Jul 2, 2019

Merged

new package id modes #1345

@memsharded memsharded changed the title Feature/package id mode simple package ID modes taking into account revisions Jul 2, 2019

@lasote lasote merged commit 3c22666 into conan-io:develop Jul 3, 2019

2 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@memsharded memsharded deleted the memsharded:feature/package_id_mode_simple branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.