Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optional management of package-id for shared libraries #5893

Merged
merged 1 commit into from Oct 16, 2019
Merged

optional management of package-id for shared libraries #5893

merged 1 commit into from Oct 16, 2019

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Oct 11, 2019 •
edited

Changelog: Feature: Implement self.info.shared_library_package_id() to better manage shared libraries package-ID, specially when they depend on static libraries
Docs: conan-io/docs#1442

#tags: slow

@memsharded memsharded added this to the 1.19.2 milestone Oct 11, 2019
lasote
lasote requested changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docs, and the explanation deserves to be especially explanatory.

jgsogo
jgsogo approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see the docs too

@memsharded
Copy link
Member Author

Docs in conan-io/docs#1442

@lasote lasote merged commit 490e845 into conan-io:release/1.19.2 Oct 16, 2019
@memsharded memsharded deleted the feature/shared_libraries_id branch October 16, 2019 10:27
@lasote lasote removed their assignment Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasote lasote lasote requested changes

@jgsogo jgsogo jgsogo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.19.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@memsharded @jgsogo @lasote