Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes cpp_info.name vs. cpp_info.names issue in pkg_config generator #6223

Merged
merged 2 commits into from Jan 7, 2020

Conversation

@danimtb
Copy link
Member

danimtb commented Dec 12, 2019

Changelog: Bugfix: Fixes cpp_info.name vs. cpp_info.names issue in pkg_config generator
Docs: omit

TARGET THIS TO NEW RELEASE BRANCH Done!

  • Refer to the issue that supports this Pull Request: closes #6211 closes #6222
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

@danimtb danimtb self-assigned this Dec 12, 2019
@danimtb danimtb mentioned this pull request Dec 12, 2019
3 of 5 tasks complete
@danimtb danimtb added this to the 1.21.1 milestone Dec 12, 2019
@ericLemanissier

This comment has been minimized.

Copy link
Contributor

ericLemanissier commented Dec 12, 2019

That should do it

@danimtb danimtb requested review from lasote and czoido Dec 13, 2019
@danimtb danimtb marked this pull request as ready for review Dec 13, 2019
@czoido
czoido approved these changes Dec 13, 2019
Copy link
Member

jgsogo left a comment

There is a new branch release/1.21.1, this PR should be changed to target that one.

@danimtb danimtb changed the base branch from develop to release/1.21.1 Dec 20, 2019
@danimtb

This comment has been minimized.

Copy link
Member Author

danimtb commented Dec 20, 2019

Done!

@memsharded memsharded merged commit 72f936d into conan-io:release/1.21.1 Jan 7, 2020
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.