Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator 'pkg_config': same logic as others to get the names #7171

Closed
wants to merge 3 commits into from

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Jun 9, 2020

Changelog: Fix: Generator pkg_config uses the same logic as the rest of them to get the name of the generated files.
Docs: omit

This PR rollback changes introduced in #6223 that were fixing some issues reported before cpp_info.names was introduced. Now that the recipe writer has full control over the generated .pc filename using cpp_info.names['pkg_config'] = 'xxxx' IMHO it makes no sense to keep this behavior here.

@jgsogo
Copy link
Contributor Author

jgsogo commented Jun 9, 2020

@memsharded @danimtb I really think we can (and should) get rid of this custom logic for this generator, wdyt?

@memsharded
Copy link
Member

@memsharded @danimtb I really think we can (and should) get rid of this custom logic for this generator, wdyt?

I would really like to fix it, but as I see it, this would be breaking behavior. And most likely it will break pkg_config generator users.

@jgsogo
Copy link
Contributor Author

jgsogo commented Jun 10, 2020

Ok. let's make this change in Conan v2 and meanwhile I'll try a different approach

@jgsogo jgsogo closed this Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants